Skip to content

fix: fixing recent migration file downgrade lineage#24394

Closed
zephyring wants to merge 1 commit intoapache:masterfrom
preset-io:zef/fix_migration_lineage
Closed

fix: fixing recent migration file downgrade lineage#24394
zephyring wants to merge 1 commit intoapache:masterfrom
preset-io:zef/fix_migration_lineage

Conversation

@zephyring
Copy link

SUMMARY

  1. recently introduced migration file drop_access_request has a downgrade version in future migration file.
  2. This PR should fix the order in order to unblock certain people from getting stuck on db migration.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zephyring zephyring requested a review from a team as a code owner June 13, 2023 21:17
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #24394 (f463576) into master (62b4564) will not change coverage.
The diff coverage is n/a.

❗ Current head f463576 differs from pull request most recent head bab1c52. Consider uploading reports for the commit bab1c52 to get more accurate results

@@           Coverage Diff           @@
##           master   #24394   +/-   ##
=======================================
  Coverage   68.98%   68.98%           
=======================================
  Files        1903     1903           
  Lines       74126    74126           
  Branches     8110     8110           
=======================================
  Hits        51138    51138           
  Misses      20876    20876           
  Partials     2112     2112           
Flag Coverage Δ
hive 54.01% <ø> (ø)
mysql 79.30% <ø> (ø)
postgres 79.38% <ø> (ø)
presto 53.93% <ø> (ø)
python 83.35% <ø> (ø)
sqlite 77.88% <ø> (ø)
unit 54.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hold until we can review

@zephyring zephyring closed this Jun 14, 2023
@zephyring zephyring deleted the zef/fix_migration_lineage branch August 9, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants