Skip to content

Conversation

@betodealmeida
Copy link
Member

SUMMARY

Skipping the Hive test that is failing with a message that doesn't make sense. It complains about this generated query not being valid due to the GROUP 1, even though it is valud:

SELECT
  `name` AS `name`,
  SUM(num) AS `sum__num`
FROM `birth_names`
WHERE
  `ds` >= CAST('1924-03-14 00:00:00.000000' AS TIMESTAMP)
  AND `ds` < CAST('2024-03-14 21:34:33.000000' AS TIMESTAMP)
  AND `gender` = 'boy'
  AND NOT `num` IS NULL
  AND NOT (
    `name` IS NULL OR `name` IN ('"abc"')
  )
GROUP BY
  1
ORDER BY
  `sum__num` DESC
LIMIT 100;

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.46%. Comparing base (ad7bd09) to head (ced352b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #27590   +/-   ##
=======================================
  Coverage   67.46%   67.46%           
=======================================
  Files        1910     1910           
  Lines       74802    74802           
  Branches     8345     8345           
=======================================
  Hits        50468    50468           
  Misses      22283    22283           
  Partials     2051     2051           
Flag Coverage Δ
mysql 77.99% <ø> (ø)
postgres 78.14% <ø> (ø)
python 78.27% <ø> (ø)
sqlite 77.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas rusackas deleted the skip-hive-test branch March 21, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants