Skip to content

fix(helm): set chart appVersion to 4.0.2#30579

Closed
alecodev wants to merge 1 commit intoapache:masterfrom
alecodev:fix/helm-4.0.2
Closed

fix(helm): set chart appVersion to 4.0.2#30579
alecodev wants to merge 1 commit intoapache:masterfrom
alecodev:fix/helm-4.0.2

Conversation

@alecodev
Copy link

SUMMARY

Fixed Helm version to match latest release

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@rusackas
Copy link
Member

Ruh roh... thanks for the approval @dpgaspar but it seems we didn't merge this fast enough! @alecodev could you rebase/update the PR, and we'll try to snipe the merge button a little faster this time?

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after rebasing and setting the correct new chart version number (patch bump). FYI we're planning on moving to latest tag after 4.1.0 release for latest stable version, so these types of bump chores won't be needed in the future.

@rusackas
Copy link
Member

Moving this to draft mode, hopeful that @alecodev comes back to touch it up and mark it as "ready for review" again :)

@rusackas rusackas marked this pull request as draft November 11, 2024 17:06
@MattpaulKing
Copy link

watching

@rusackas
Copy link
Member

I'm assuming @alecodev isn't coming back to rebase this... closing for now, but happy to reopen as needed.

@rusackas rusackas closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants