Skip to content

feat(sunburst): Add node click functionality to sunburst chart#31478

Closed
gerbermichi wants to merge 1 commit intoapache:masterfrom
gerbermichi:echart-sunburst-drilldown
Closed

feat(sunburst): Add node click functionality to sunburst chart#31478
gerbermichi wants to merge 1 commit intoapache:masterfrom
gerbermichi:echart-sunburst-drilldown

Conversation

@gerbermichi
Copy link
Contributor

SUMMARY

This feature introduces node click functionality to the sunburst chart. Users can now click on nodes to focus on one node, enhancing the interactivity and usability of the chart.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image image

TESTING INSTRUCTIONS

Create a sunburst chart with multiple hierarchies.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the viz:charts:sunburst Related to the Sunburst chart label Dec 16, 2024
@rusackas
Copy link
Member

/testenv up

name: 'node_click',
config: {
type: 'CheckboxControl',
label: t('Node Click'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use a label that describes the feature it enables rather than action? Like label: t('Enable drill down'),?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kgabryje I'm wondering what's the relationship of this feature with cross-filtering and drill by? By default, charts offer the left click for cross-filtering and the right-click for the menu options. They don't offer controls to enable/disable this behavior if I'm not mistaken. I wonder if we should just add support for left/right clicks as the other chart types do.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh you're right, this feature would be in conflict with cross filtering. I wonder if it would make sense to trigger drill down with some combination like ctrl + left click. Of course then we'd need some tooltip in chart itself for discoverability

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not implement drill down using drill by as we do for all chart types?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugins size/S viz:charts:sunburst Related to the Sunburst chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants