refactor(theme): Move colors to lightConfig#31719
refactor(theme): Move colors to lightConfig#31719msyavuz wants to merge 1 commit intoapache:masterfrom
Conversation
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Fix Detected |
|---|---|---|
 |
Simplify the lightConfig object structure. ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/theme/index.ts | ✅ |
| superset-frontend/src/theme/light.ts | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Naming ✅ Database Operations ✅ Documentation ✅ Logging ✅ Error Handling ✅ Systems and Environment ✅ Objects and Data Structures ✅ Readability and Maintainability ✅ Asynchronous Processing ✅ Design Patterns ✅ Third-Party Libraries ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
| }; | ||
| }; | ||
|
|
||
| export const lightConfig: ThemeConfig = { |
There was a problem hiding this comment.
Simplify the lightConfig object structure. 
Tell me more
It appears that the lightConfig object is becoming quite complex and monolithic with maintaining colors, themes, and configuration components inside one large object. This could limit the scalability of your theme setup. I suggest you consider breaking down the lightConfig object into smaller, more manageable configuration units. This will increase the maintainability and simplicity of the configuration code. An appropriate design pattern like the Module or Factory pattern can be employed to achieve this modularity.
Chat with Korbit by mentioning @korbit-ai, and give a 👍 or 👎 to help Korbit improve your reviews.
|
Putting a hold on this as there are discussions on theming going on right now that could already include this. |
2 participants
SUMMARY
Current implementation of Ant Design theme is based on Superset having a single light theme. To enable theming capabilities colors need to be seperated to their own lightConfig. This pr aims to do that. After this, adding a dark mode can be done by copying the light theme and changing colors.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Run the tests and visually check if there are any regressions.
ADDITIONAL INFORMATION