fix(docker compose): replace port 8088 with 9000#32481
Merged
mistercrunch merged 1 commit intoapache:masterfrom Mar 3, 2025
Merged
fix(docker compose): replace port 8088 with 9000#32481mistercrunch merged 1 commit intoapache:masterfrom
mistercrunch merged 1 commit intoapache:masterfrom
Conversation
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Documentation ✅ Logging ✅ Error Handling ✅ Readability ✅ Design ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
3 tasks
jpchev
changed the title
jpchev
changed the title
jpchev
changed the title
rusackas
reviewed
Mar 3, 2025
| SCARF_ANALYTICS: "${SCARF_ANALYTICS:-}" | ||
| # configuring the dev-server to use the host.docker.internal to connect to the backend | ||
| superset: "http://host.docker.internal:8088" | ||
| superset: "http://superset:8088" |
Member
There was a problem hiding this comment.
This seems to work, but I'm not sure if/why the change is needed.
Contributor
Author
There was a problem hiding this comment.
on my linux machine, host.docker.internal doesn't seem to work, I don't know if I need some extraconfiguration, but I'd rather ask why is host.docker.internal needed, instead of just simply calling the superset service?
host.docker.internal calls a service on the underlying host network, why is this needed?
Member
There was a problem hiding this comment.
asked GPT about it and seems this is a better approach -> https://chatgpt.com/share/67c6330b-9500-8010-b26a-0e1666025dea
mistercrunch
approved these changes
Mar 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR is to fix the
docker-compose.yml, see#32426 (comment)