fix(OAuth2): Update connection should not fail if connection is missing OAuth2 token #33100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset/commands/database/exceptions.py | ✅ |
| superset/commands/database/update.py | ✅ |
| superset/commands/database/sync_permissions.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Current Korbit Configuration
General Settings
Setting Value Review Schedule Automatic excluding drafts Max Issue Count 10 Automatic PR Descriptions ❌ Issue Categories
Category Enabled Documentation ✅ Logging ✅ Error Handling ✅ Readability ✅ Design ✅ Performance ✅ Security ✅ Functionality ✅ Feedback and Support
Note
Korbit Pro is free for open source projects 🎉
Looking to add Korbit to your team? Get started with a free 2 week trial here
Vitor-Avila
force-pushed
the
fix/update-oauth2-connections
branch
from
cf8d884 to
a3a7391
Compare
betodealmeida
approved these changes
Apr 11, 2025
Comment on lines
+119
to
+122
| if ( | ||
| self.db_connection.is_oauth2_enabled() | ||
| and self.db_connection.db_engine_spec.needs_oauth2(err) | ||
| ): |
Member
There was a problem hiding this comment.
In the near future we should DRY this code, we use it a lot.
Contributor
Author
There was a problem hiding this comment.
That's a good callout. I'll merge this one for now but I'll keep this in mind.
michael-s-molina
added
v5.0
alexandrusoare
pushed a commit
to alexandrusoare/superset
that referenced
this pull request
Jun 19, 2025
…ng OAuth2 token (apache#33100) (cherry picked from commit a5a91d5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The
UpdateDatabaseCommandcommand calls theSyncPermissionsCommandto reflect new datasources into Roles (for data access). The update itself might purge all OAuth2 tokens, or the user performing the change might not have a valid token yet, so the update should not fail in case the token is missing.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
No UI changes.
TESTING INSTRUCTIONS
Test coverage added.
ADDITIONAL INFORMATION