fix(sqllab): query deletion not updating UI in query history#34334
Closed
mistercrunch wants to merge 1 commit intomasterfrom
Closed
fix(sqllab): query deletion not updating UI in query history#34334mistercrunch wants to merge 1 commit intomasterfrom
mistercrunch wants to merge 1 commit intomasterfrom
Conversation
The delete API call succeeded but the RTK Query cache wasn't invalidated, causing deleted queries to remain visible until page refresh. Added cache invalidation to immediately update the UI. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Missing Cache Invalidation on Error ▹ view | 🧠 Not in standard |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/SqlLab/actions/sqlLab.js | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
| .then(() => { | ||
| dispatch({ type: REMOVE_QUERY, query }); | ||
| // Invalidate RTK Query cache to update the UI | ||
| dispatch(api.util.invalidateTags(['EditorQueries'])); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The delete API call succeeded but the RTK Query cache wasn't invalidated, causing deleted queries to remain visible until page refresh. Added cache invalidation to immediately update the UI.
Also fixing various issues in
Query History, ordering was wrong, failed status wasn't reported properly, ...Actually deadended here, will require more time/attention to fix