Skip to content

Conversation

@drummerwolli
Copy link
Contributor

SUMMARY

It's currently not possible to deep link to one available macro in the page because the headers are just bold text. switching to proper Markdown headers fixes this.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the doc Namespace | Anything related to documentation label Oct 16, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
docs/docs/configuration/sql-templating.mdx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@sadpandajoe sadpandajoe added the review:checkpoint Last PR reviewed during the daily review standup label Oct 16, 2025
Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement! Thanks for the clear explanation too.

@sfirke sfirke merged commit 3db613d into apache:master Oct 17, 2025
67 checks passed
@rusackas rusackas removed the review:checkpoint Last PR reviewed during the daily review standup label Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Namespace | Anything related to documentation size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants