fix(permalink): exclude edit mode from dashboard permalink #35889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
dosubot
bot
added
change:frontend
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/utils/urlUtils.ts | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
villebro
reviewed
Nov 10, 2025
Member
villebro
left a comment
villebro
left a comment
There was a problem hiding this comment.
Thanks for addressing this! Minor refactor suggestion to automatically remove the edit param.
sadpandajoe
added
the
v6.0
sadpandajoe
pushed a commit
that referenced
this pull request
Nov 12, 2025
(cherry picked from commit e2e831e)
aminghadersohi
pushed a commit
to aminghadersohi/superset
that referenced
this pull request
Nov 17, 2025
kshi020302
pushed a commit
to jl141/superset
that referenced
this pull request
Nov 30, 2025
github-actions
bot
added
🍒 6.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Exclude edit mode query parameter from dashboard permalinks to prevent going into edit mode by accident when sharing permalinks. User's accessing the dashboard would not expect to go into edit mode directly.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION