fix(dashboard): abort previous chart queries when filters change to p…

[richardfogaca]

SUMMARY

Fixes cross-filter persistence bug where removing filters before charts finish loading leaves charts displaying stale
filtered data despite filters being cleared from the UI.

Root Cause: The CHART_UPDATE_STARTED reducer replaces the previous query's AbortController without calling
.abort(), allowing in-flight requests to complete with outdated filter values.

The Fix: Abort previous AbortController before replacing it (3-line change), matching the pattern already used
for annotation queries.

Impact:

• Fixes data inconsistency where UI shows cleared filters but charts display filtered data
• Prevents race conditions when filters change rapidly
• Ensures latest filter state always wins

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
In this case "Planes" was the cross-filter selected and then removed, but the charts did not rehydrate back:

AFTER:
No filters are applied when cross-filter is cleared:

TESTING INSTRUCTIONS

1. Configure async mode
2. Open Sales Dashboard (or any dashboard with cross-filtering enabled)
3. Click a chart element (bar/segment) to create a cross-filter
4. Immediately click the X icon to remove the cross-filter
5. Expected: All charts reload without the cross-filter applied

ADDITIONAL INFORMATION

• Has associated issue: Fixes Cross-filter persists after removal, leaving dashboard in inconsistent filtered state (6.0.0rc2) #35623
• Required feature flags:
• Changes UI
• Includes DB Migration
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #ffff65

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: cdfb4e5..cdfb4e5

  • superset-frontend/src/components/Chart/chartReducer.ts
• Files skipped - 0
• Tools

  • Eslint (Linter) - ✔︎ Successful
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[korbit-ai]

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	State mutation in Redux reducer ▹ view
	State mutation in Redux reducer ▹ view

Files scanned

​

File Path	Reviewed
superset-frontend/src/components/Chart/chartReducer.ts	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X