feat: added deterministic field generation to dashboard export

[Debaoss]

SUMMARY

Instead of using randomly generated suffixes for rows and charts in export, now uses sequential row number for the row's id field and a chart's uuid for its id field (but not its chartId field).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Backend change, not applicable.

TESTING INSTRUCTIONS

pytest -q tests/unit_tests/dashboards/export_append_charts_tests.py

ADDITIONAL INFORMATION

• Has associated issue: Superset uses random to generate fields in export format #32987
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #7fc8fc

Actionable Suggestions - 0

Review Details

• Files reviewed - 2 · Commit Range: fa923dd..e5352ab

  • superset/commands/dashboard/export.py
  • tests/unit_tests/dashboards/export_append_charts_tests.py
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • MyPy (Static Code Analysis) - ✔︎ Successful
  • Astral Ruff (Static Code Analysis) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by