Skip to content

Conversation

@SBIN2010
Copy link
Contributor

@SBIN2010 SBIN2010 commented Nov 30, 2025

SUMMARY

This PR fix #36337

The missing required parameters are added for the datasource:
name,
columns,
metrics.
And type as DatasourceType

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Снимок экрана от 2025-11-30 20-49-28

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

SBIN2010 and others added 30 commits October 22, 2024 23:07
@bito-code-review
Copy link
Contributor

bito-code-review bot commented Nov 30, 2025

Code Review Agent Run #07547b

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 19151d1..4104b3b
    • superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Polygon/transformProps.test.ts
  • Files skipped - 0
  • Tools
    • Eslint (Linter) - ✔︎ Successful
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot bot added the viz:charts:deck.gl Related to deck.gl charts label Nov 30, 2025
@SBIN2010
Copy link
Contributor Author

Duplicate #36336

@SBIN2010 SBIN2010 closed this Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type '"table"' is not assignable to type 'DatasourceType'.

1 participant