fix(mypy): add overrides for superset-core local dev consistency #36907
Conversation
When superset-core is installed as an editable dependency locally, mypy can see its type information and flags type: ignore comments as unused. In CI, the types aren't exposed the same way, so those comments are still needed. This adds mypy overrides to: 1. Skip following imports from superset_core module 2. Disable warn_unused_ignores for modules with dynamic type assignments that need type: ignore in CI Fixes local pre-commit mypy failures that don't occur in CI. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Code Review Agent Run #7cabc2Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
codeant-ai-for-open-source
bot
added
the
size:S
|
CodeAnt AI finished reviewing your PR. |
💡 Enhance Your PR ReviewsWe noticed that 3 feature(s) are not configured for this repository. Enabling these features can help improve your code quality and workflow: 🚦 Quality GatesStatus: Quality Gates are not enabled at the organization level 🎫 Jira Ticket ComplianceStatus: Jira credentials file not found. Please configure Jira integration in your settings ⚙️ Custom RulesStatus: No custom rules configured. Add rules via organization settings or .codeant/review.json in your repository Want to enable these features? Contact your organization admin or check our documentation for setup instructions. |
There was a problem hiding this comment.
Pull request overview
This PR adds mypy configuration overrides to ensure consistent behavior between local development (where superset-core is installed as an editable dependency) and CI environments (where type information from superset-core may not be exposed the same way).
Key Changes:
- Added mypy override to skip following imports from
superset_core.*module - Disabled
warn_unused_ignoresfor seven modules that perform dynamic type assignments and require# type: ignorecomments for CI compatibility
1 participant
User description
Summary
When
superset-coreis installed as an editable dependency locally (viaapache-superset-core = { path = "./superset-core", editable = true }), mypy can see its type information and flags# type: ignorecomments as unused. In CI, the types aren't exposed the same way, so those comments are still needed.This adds mypy overrides to:
superset_coremodulewarn_unused_ignoresfor modules with dynamic type assignments that need# type: ignorein CIAffected modules:
superset.core.api.core_api_injectionsuperset.security.managersuperset.daos.basesuperset.connectors.sqla.modelssuperset.tags.filterssuperset.commands.security.updatesuperset.commands.security.createBefore/After
Before: Local pre-commit mypy fails with 26 "Unused type: ignore comment" errors
After: Local pre-commit mypy passes, matching CI behavior
Test Plan
pre-commit run mypy --files superset/core/api/core_api_injection.pypasses locallyAdditional Information
This issue started appearing for developers with local editable installs of superset-core after the superset-core package was introduced. The fix ensures consistent behavior between local development and CI environments.
🤖 Generated with Claude Code
CodeAnt-AI Description
Add mypy overrides so local checks match CI when superset-core is editable
What Changed
Impact
✅ Fewer local mypy failures during pre-commit✅ Consistent mypy results between local development and CI✅ Shorter developer setup time when using an editable superset-core💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.