fix(deckgl): remove visibility condition in deckgl stroke color

[DamianPendrak]

Fixes #36326

SUMMARY

There was an unnecessary visibility condition for stroke color control. It was visible only when the fixed color scheme type was selected.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

After

TESTING INSTRUCTIONS

1. Create deck.gl Polygon or GeoJSON chart
2. For Polygon, verify the stroke color is visible with every color scheme type
3. For GeoJSON it should be visible all the time

ADDITIONAL INFORMATION

• Has associated issue: Regression between version 5.0.0 and version 6.0.0 of deck.gl Polygon #36326
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codeant-ai-for-open-source]

CodeAnt AI is reviewing your PR.

---

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

[bito-code-review]

Code Review Agent Run #858b66

Actionable Suggestions - 0

Additional Suggestions - 1

• superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Polygon/controlPanel.ts - 1

  • Control ordering inconsistency · Line 121-124
    strokeColorPicker appears separated from fillColorPicker in the control array, which may confuse users as both are manual color pickers; consider grouping them together for better UI organization.
    Code suggestion

     @@ -120,5 +120,5 @@
    -            fillColorPicker,
    -            deckGLLinearColorSchemeSelect,
    -            breakpointsDefaultColor,
    -            deckGLColorBreakpointsSelect,
    -            strokeColorPicker,
    +            fillColorPicker,
    +            strokeColorPicker,
    +            deckGLLinearColorSchemeSelect,
    +            breakpointsDefaultColor,
    +            deckGLColorBreakpointsSelect,

Review Details

• Files reviewed - 2 · Commit Range: 80c8d9c..d928037

  • superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Polygon/controlPanel.ts
  • superset-frontend/plugins/legacy-preset-chart-deckgl/src/utilities/Shared_DeckGL.tsx
• Files skipped - 0
• Tools

  • Eslint (Linter) - ✔︎ Successful
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[codeant-ai-for-open-source]

Nitpicks 🔍

🔒 No security issues identified

⚡ Recommended areas for review Cross-layer consistency Confirm GeoJSON and other DeckGL layer control panels have consistent stroke color visibility and behavior. The change here affects only Polygon; ensure similar behavior (and tests) exist where appropriate so users have a consistent experience across layers. Control reactivity Ensure the stroke color control updates the visualization immediately when changed (renderTrigger) and that removing the previous visibility condition does not leave the UI in an inconsistent state when certain color scheme types are selected (e.g., breakpoints or linear palettes). Visibility / UX change The stroke color control was made always visible by adding it to the color controls array. Verify that this is the intended UX for all Polygon use-cases and that the control's placement (after color breakpoints) yields expected grouping and behavior in the UI.

[codeant-ai-for-open-source]

CodeAnt AI finished reviewing your PR.

[netlify]

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	80c8d9c
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/69625a17b25b5f000882a808
😎 Deploy Preview	https://deploy-preview-37029--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[bito-code-review]

Code Review Agent Run #d52de7

Actionable Suggestions - 0

Review Details

• Files reviewed - 2 · Commit Range: 80c8d9c..d928037

  • superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Polygon/controlPanel.ts
  • superset-frontend/plugins/legacy-preset-chart-deckgl/src/utilities/Shared_DeckGL.tsx
• Files skipped - 0
• Tools

  • Eslint (Linter) - ✔︎ Successful
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by