Skip to content

Conversation

@VanessaGiannoni
Copy link

@VanessaGiannoni VanessaGiannoni commented Jan 14, 2026

SUMMARY

This feature updates the “View as table” option in dashboard chart overflow menus to display dataset column labels (verbose names) when available, instead of raw column names.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

Screenshot 2026-01-15 at 13 43 50

AFTER

Screenshot 2026-01-15 at 13 50 00

TESTING INSTRUCTIONS

  1. Open your browser and log in to Superset.
  2. Go to a dashboard with a chart that uses a dataset with column labels (verbose names).
    a. You can check/edit column labels in Data > Datasets > [Your Dataset] > Edit columns.
  3. On the dashboard, open the chart’s overflow menu (three dots).
  4. Click “View as table”.
  5. Check the table headers:
    Expected: Headers should show the dataset’s column labels (verbose names) if defined, otherwise the raw column name.
    Temporal columns: Should also show the label and still allow formatting.
  6. Run frontend tests to ensure coverage:
npm run test -- src/explore/components/DataTableControl/useTableColumns.test.ts

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@VanessaGiannoni VanessaGiannoni marked this pull request as ready for review January 14, 2026 21:37
@dosubot dosubot bot added dashboard Namespace | Anything related to the Dashboard viz:charts:table Related to the Table chart labels Jan 14, 2026
@bito-code-review
Copy link
Contributor

bito-code-review bot commented Jan 14, 2026

Code Review Agent Run #fa870e

Actionable Suggestions - 0
Review Details
  • Files reviewed - 7 · Commit Range: 838cc6f..b4ec2a8
    • superset-frontend/src/dashboard/components/SliceHeaderControls/index.tsx
    • superset-frontend/src/explore/components/DataTableControl/index.tsx
    • superset-frontend/src/explore/components/DataTableControl/useTableColumns.test.ts
    • superset-frontend/src/explore/components/DataTablesPane/components/ResultsPaneOnDashboard.tsx
    • superset-frontend/src/explore/components/DataTablesPane/components/SingleQueryResultPane.tsx
    • superset-frontend/src/explore/components/DataTablesPane/components/useResultsPane.tsx
    • superset-frontend/src/explore/components/DataTablesPane/types.ts
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Eslint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

Copy link
Contributor

@rebenitez1802 rebenitez1802 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dashboard Namespace | Anything related to the Dashboard size/M viz:charts:table Related to the Table chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants