-
Notifications
You must be signed in to change notification settings - Fork 16.5k
feat(dashboard): show dataset column labels in View as table #37140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(dashboard): show dataset column labels in View as table #37140
Conversation
…SingleQueryResultPaneProp
…ard and SingleQueryResultPane
…derCell and use columnDisplayNames in useTableColumns
…columnDisplayNames functionality
Code Review Agent Run #fa870eActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
rebenitez1802
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
geido
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
This feature updates the “View as table” option in dashboard chart overflow menus to display dataset column labels (verbose names) when available, instead of raw column names.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
AFTER
TESTING INSTRUCTIONS
a. You can check/edit column labels in Data > Datasets > [Your Dataset] > Edit columns.
Expected: Headers should show the dataset’s column labels (verbose names) if defined, otherwise the raw column name.
Temporal columns: Should also show the label and still allow formatting.
npm run test -- src/explore/components/DataTableControl/useTableColumns.test.tsADDITIONAL INFORMATION