fix(timeseries): restore ECharts tooltip after closing drill menu #37284

VanessaGiannoni · 2026-01-20T13:09:26Z

SUMMARY

Right-clicking a Timeseries/Area chart to open the drill menu caused ECharts tooltips to stop appearing until page refresh. Tooltips are gated by an “in context menu” state, but visibility was not restored on close.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

Before

tooltip-failing.mov

TESTING INSTRUCTIONS

Create an Area chart with tooltips enabled and add it to a dashboard.
On the dashboard:
- Right-click on the chart to open the drill menu.
- Click anywhere to close the drill menu.
- Hover the chart and confirm the tooltip appears again.

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

…loses

codeant-ai-for-open-source · 2026-01-20T13:09:33Z

CodeAnt AI is reviewing your PR.

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

bito-code-review · 2026-01-20T13:09:37Z

Code Review Agent Run #3bb82a

Actionable Suggestions - 0

Review Details

Files reviewed - 1 · Commit Range: 0a3bd87..0a3bd87
- superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

netlify · 2026-01-20T13:12:57Z

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	`0a3bd87`
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/696f7e8ab5869c0008e3414a
😎 Deploy Preview	https://deploy-preview-37284--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

codeant-ai-for-open-source · 2026-01-20T13:13:05Z

CodeAnt AI finished reviewing your PR.

superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.tsx

bito-code-review · 2026-01-20T16:34:37Z

The current change adds a workaround to restore tooltip visibility after drill menu interactions using a mousedown listener. For a higher-layer fix, consider modifying the drill menu logic to avoid hiding the tooltip altogether, perhaps by adjusting ECharts options or event handling in the menu component itself.

…ter drill menu closes

codeant-ai-for-open-source · 2026-01-21T22:52:12Z

CodeAnt AI is running Incremental review

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

codeant-ai-for-open-source · 2026-01-21T22:55:18Z

CodeAnt AI Incremental review completed.

bito-code-review · 2026-01-21T23:54:12Z

Code Review Agent Run #871c37

Actionable Suggestions - 0

Review Details

Files reviewed - 1 · Commit Range: 0a3bd87..2479846
- superset-frontend/src/components/Chart/ChartContextMenu/ChartContextMenu.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

msyavuz

Can we add a regression test for this?

superset-frontend/src/components/Chart/ChartContextMenu/ChartContextMenu.test.tsx

…ext menu interactions

VanessaGiannoni · 2026-01-23T20:35:02Z

Can we add a regression test for this?

Of course!

bito-code-review

Code Review Agent Run #dcd3e1

Actionable Suggestions - 1

superset-frontend/src/components/Chart/ChartContextMenu/ChartContextMenu.test.tsx - 1
- Test assertion incorrect for restoration · Line 145-145

Review Details

Files reviewed - 2 · Commit Range: 2479846..debe7db
- superset-frontend/src/components/Chart/ChartContextMenu/ChartContextMenu.test.tsx
- superset-frontend/src/components/Chart/ChartContextMenu/ChartContextMenu.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

bito-code-review · 2026-01-23T21:50:21Z

superset-frontend/src/components/Chart/ChartContextMenu/ChartContextMenu.test.tsx

+  userEvent.click(menuItem);
+
+  await waitFor(() => {
+    expect(screen.getByTestId('tooltip-visible')).toBeInTheDocument();


Test assertion incorrect for restoration

The test expects tooltip visible when menu opens, but for restoration testing, it should be hidden.

Code suggestion

Check the AI-generated fix before applying

Suggested change

expect(screen.getByTestId('tooltip-visible')).toBeInTheDocument();

expect(screen.queryByTestId('tooltip-visible')).not.toBeInTheDocument();

Code Review Run #dcd3e1

Should Bito avoid suggestions like this for future reviews? (Manage Rules)

Yes, avoid them

fix(EchartsTimeseries): restore tooltip visibility after drill menu c…

0a3bd87

…loses

pull-request-size bot added the size/S label Jan 20, 2026

github-actions bot added the plugins label Jan 20, 2026

dosubot bot added the viz:charts:timeseries Related to Timeseries label Jan 20, 2026

geido reviewed Jan 20, 2026

View reviewed changes

superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.tsx Outdated Show resolved Hide resolved

VanessaGiannoni added 2 commits January 21, 2026 19:51

fix(EchartsTimeseries): remove redundant tooltip restoration logic af…

eb10d60

…ter drill menu closes

fix(ChartContextMenu): call onClose when context menu is closed

b828cc3

pull-request-size bot added size/XS and removed size/S labels Jan 21, 2026

VanessaGiannoni requested a review from geido January 21, 2026 22:57

fix(EchartsTimeseries): remove unnecessary blank line

2479846

github-actions bot removed the plugins label Jan 21, 2026

msyavuz reviewed Jan 23, 2026

View reviewed changes

test(ChartContextMenu): add tests for context menu close behavior

86103ba

pull-request-size bot added size/L and removed size/XS labels Jan 23, 2026

codeant-ai-for-open-source bot reviewed Jan 23, 2026

View reviewed changes

superset-frontend/src/components/Chart/ChartContextMenu/ChartContextMenu.test.tsx Show resolved Hide resolved

fix(ChartContextMenu): restore tooltip visibility in tests after cont…

debe7db

…ext menu interactions

VanessaGiannoni requested a review from msyavuz January 23, 2026 20:35

bito-code-review bot reviewed Jan 23, 2026

View reviewed changes

	expect(screen.getByTestId('tooltip-visible')).toBeInTheDocument();
	expect(screen.queryByTestId('tooltip-visible')).not.toBeInTheDocument();

fix(timeseries): restore ECharts tooltip after closing drill menu #37284

Are you sure you want to change the base?

fix(timeseries): restore ECharts tooltip after closing drill menu #37284

Conversation

VanessaGiannoni commented Jan 20, 2026

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

Before

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

codeant-ai-for-open-source bot commented Jan 20, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

bito-code-review bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #3bb82a

Uh oh!

netlify bot commented Jan 20, 2026

✅ Deploy Preview for superset-docs-preview ready!

Uh oh!

codeant-ai-for-open-source bot commented Jan 20, 2026

Uh oh!

Uh oh!

bito-code-review bot commented Jan 20, 2026

Uh oh!

codeant-ai-for-open-source bot commented Jan 21, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

codeant-ai-for-open-source bot commented Jan 21, 2026

Uh oh!

bito-code-review bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #871c37

Uh oh!

msyavuz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

VanessaGiannoni commented Jan 23, 2026

Uh oh!

bito-code-review bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Code Review Agent Run #dcd3e1

Uh oh!

bito-code-review bot Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bito-code-review bot commented Jan 20, 2026 •

edited

Loading

bito-code-review bot commented Jan 21, 2026 •

edited

Loading

bito-code-review bot left a comment •

edited

Loading