-
Notifications
You must be signed in to change notification settings - Fork 16.6k
docs: show Developer Portal in global navigation #37313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Enable the Developer Portal navigation item in the global navbar. The section was previously hidden via hideFromNav flag while the content was being developed, but is ready for visibility. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Bito Automatic Review Skipped - Files Excluded |
Sequence DiagramThis PR flips the docs configuration to expose the "Developer Portal" in the global navbar. The diagram shows the build/runtime config being read and the user discovering and navigating to the Developer Portal from the top navigation. sequenceDiagram
participant User
participant Browser
participant DocsSite
participant ConfigFile
Browser->>DocsSite: Request site (page load / build)
DocsSite->>ConfigFile: Read versions-config.json (hideFromNav: false)
ConfigFile-->>DocsSite: Developer Portal enabled
DocsSite-->>Browser: Render navbar with "Developer Portal" dropdown
User->>Browser: Click "Developer Portal" -> select dropdown item
Browser->>DocsSite: Navigate to selected Developer Portal page
DocsSite-->>Browser: Serve Developer Portal content
Generated by CodeAnt AI |
|
CodeAnt AI finished reviewing your PR. |
The navbar item for Extensions was referencing 'extensions/architectural-principles' but the actual doc file is 'extensions/architecture'. This caused the build to fail when the Developer Portal became visible in the navbar. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Update links that pointed to the old /docs/configuration/databases path to use the new /docs/databases path with correct anchors. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review Agent Run #773956
Actionable Suggestions - 1
-
docs/docs/configuration/timezones.mdx - 1
- Broken documentation link · Line 23-23
Additional Suggestions - 1
-
docs/docs/configuration/timezones.mdx - 1
-
Spelling error in docs · Line 23-23The term 'serializd' is a spelling error; it should be 'serialized' to correctly describe the JSON serialization process.
Code suggestion
@@ -23,1 +23,1 @@ -The challenge however lies with the slew of [database engines](/docs/databases#installing-drivers-in-docker) which Apache Superset supports and various inconsistencies between their [Python Database API (DB-API)](https://www.python.org/dev/peps/pep-0249/) implementations combined with the fact that we use [Pandas](https://pandas.pydata.org/) to read SQL into a DataFrame prior to serializing to JSON. Regrettably Pandas ignores the DB-API [type_code](https://www.python.org/dev/peps/pep-0249/#type-objects) relying by default on the underlying Python type returned by the DB-API. Currently only a subset of the supported database engines work correctly with Pandas, i.e., ensuring timestamps without an explicit timestamp are serializd to JSON with the server timezone, thus guaranteeing the client will display timestamps in a consistent manner irrespective of the client's timezone. +The challenge however lies with the slew of [database engines](/docs/databases#installing-drivers-in-docker) which Apache Superset supports and various inconsistencies between their [Python Database API (DB-API)](https://www.python.org/dev/peps/pep-0249/) implementations combined with the fact that we use [Pandas](https://pandas.pydata.org/) to read SQL into a DataFrame prior to serializing to JSON. Regrettably Pandas ignores the DB-API [type_code](https://www.python.org/dev/peps/pep-0249/#type-objects) relying by default on the underlying Python type returned by the DB-API. Currently only a subset of the supported database engines work correctly with Pandas, i.e., ensuring timestamps without an explicit timestamp are serialized to JSON with the server timezone, thus guaranteeing the client will display timestamps in a consistent manner irrespective of the client's timezone.
-
Review Details
-
Files reviewed - 5 · Commit Range:
f9e0634..d4e8513- docs/docs/configuration/timezones.mdx
- docs/docs/faq.mdx
- docs/docs/installation/kubernetes.mdx
- docs/docs/quickstart.mdx
- docs/docusaurus.config.ts
-
Files skipped - 2
- docs/src/data/databases.json - Reason: Filter setting
- docs/versions-config.json - Reason: Filter setting
-
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
|
When I click on Developer Portal -> Extensions it's redirecting me to Architecture but I think it should be Overview. |
michael-s-molina
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rusackas I left a non-blocking comment that would be nice to address before merging.
The Extensions link in the Developer Portal navbar should go to the overview page, not directly to the architecture page. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Bito Automatic Review Skipped – PR Already Merged |
SUMMARY
Enable the Developer Portal navigation item in the global navbar. The section was previously hidden via
hideFromNav: trueindocs/versions-config.jsonwhile the content was being developed, but is now ready for public visibility.This makes the Developer Portal accessible from the top navigation bar, alongside Documentation and Community Resources.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: Developer Portal not visible in navbar
After: Developer Portal appears in navbar with dropdown menu (Overview, Extensions, Testing, Guidelines, Contributing)
TESTING INSTRUCTIONS
cd docs && npm run buildnpm run serveADDITIONAL INFORMATION
🤖 Generated with Claude Code