Skip to content

feat: provide full endpoint URL construction for plugin developers #37360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
innovark37 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: provide full endpoint URL construction for plugin developers #37360

innovark37 wants to merge 2 commits into from

Conversation

@innovark37
Copy link
Contributor

@innovark37 innovark37 commented Jan 22, 2026

SUMMARY

This PR provides plugin developers with the ability to construct fully-qualified Superset endpoint URLs, including the application root prefix, regardless of deployment configuration.

The Core Problem

External plugins lack access to Superset's deployment context and cannot reliably construct endpoint URLs. When Superset is deployed at a non-root path (e.g., /superset, /analytics, custom prefix), plugins have no way to know this prefix and thus cannot create correct URLs.

Solution

Expose a getUrl() method via SupersetClient (already available through @superset-ui/core) that resolves paths with the correct application context.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Jan 22, 2026 •
edited
Loading

Code Review Agent Run #a313b2

Actionable Suggestions - 0
Review Details
  • Files reviewed - 3 · Commit Range: 342351e..366bd3b
    • superset-frontend/packages/superset-ui-core/src/connection/SupersetClient.ts
    • superset-frontend/packages/superset-ui-core/src/connection/types.ts
    • superset-frontend/packages/superset-ui-core/test/connection/SupersetClient.test.ts
  • Files skipped - 0
  • Tools
    • Eslint (Linter) - ✔︎ Successful
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot bot added the api Related to the REST API label Jan 22, 2026
@netlify
Copy link

netlify bot commented Jan 22, 2026

✅ Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 342351e
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/6971fce662d5200008ab6fa7
😎 Deploy Preview https://deploy-preview-37360--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot removed the api Related to the REST API label Jan 22, 2026
@bito-code-review
Copy link
Contributor

bito-code-review bot commented Jan 22, 2026 •
edited
Loading

Code Review Agent Run #24a77f

Actionable Suggestions - 0
Review Details
  • Files reviewed - 3 · Commit Range: 342351e..366bd3b
    • superset-frontend/packages/superset-ui-core/src/connection/SupersetClient.ts
    • superset-frontend/packages/superset-ui-core/src/connection/types.ts
    • superset-frontend/packages/superset-ui-core/test/connection/SupersetClient.test.ts
  • Files skipped - 0
  • Tools
    • Eslint (Linter) - ✔︎ Successful
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

packages size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@innovark37