fix: d3 format for table #37454
fix: d3 format for table #37454
Conversation
This reverts commit 35aaeb6.
dosubot
bot
added
change:frontend
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #5daef7
Actionable Suggestions - 1
-
superset-frontend/src/explore/components/controls/ColumnConfigControl/constants.tsx - 1
- Inappropriate tokenSeparators for single select · Line 61-61
Review Details
-
Files reviewed - 2 · Commit Range:
19151d1..354dee8- superset-frontend/packages/superset-ui-chart-controls/src/types.ts
- superset-frontend/src/explore/components/controls/ColumnConfigControl/constants.tsx
-
Files skipped - 0
-
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
AI Code Review powered by
| creatable: true, | ||
| minWidth: '14em', | ||
| debounceDelay: 500, | ||
| tokenSeparators: ['\r\n', '\n', '\t', ';'], |
There was a problem hiding this comment.
The tokenSeparators property enables pasting multi-line text into this single-value select control, which can result in invalid D3 format strings containing newlines. Since the control expects a single string value and tokenSeparators are intended for multi-select scenarios, this should be removed to avoid potential incorrect input.
Code suggestion
Check the AI-generated fix before applying
- minWidth: '14em',
- debounceDelay: 500,
- tokenSeparators: ['\\r\\n', '\\n', '\\t', ';'],
- };
+ minWidth: '14em',
+ debounceDelay: 500,
+ };
Code Review Run #5daef7
Should Bito avoid suggestions like this for future reviews? (Manage Rules)
- Yes, avoid them
Code Review Agent Run #5c97efActionable Suggestions - 0Additional Suggestions - 1
Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
1 participant
SUMMARY
This PR fix #37038
By default, the comma is the separator for 'Select'.
This PR redefines the separator array, excluding the comma from it.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION