feat: use dataset labels in drill by modal

[phmoraesrodrigues]

SUMMARY

Add Drill By modal test coverage to ensure label_map column labels are applied in results table rendering and data still displays correctly.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

1. Create a new metric to your test dataset. Make sure this metric has a label.
2. Create a table chart (this is reproducible with both legacy and V2) and add this metric to the chart.
3. Add any dimension.
4. Save the chart and add it to a dashboard.
5. Access the dashboard.
6. Right click on a dimension value > Drill by and choose a column.
7. Check the metric in the Drill By menu.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #4dd57a

Actionable Suggestions - 0

Review Details

• Files reviewed - 3 · Commit Range: 4471cc6..4471cc6

  • superset-frontend/packages/superset-ui-core/src/query/types/QueryResponse.ts
  • superset-frontend/src/components/Chart/DrillBy/DrillByModal.test.tsx
  • superset-frontend/src/components/Chart/DrillBy/DrillByModal.tsx
• Files skipped - 0
• Tools

  • Eslint (Linter) - ✔︎ Successful
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[netlify]

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	4471cc6
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/697828a56607f70008ae96b6
😎 Deploy Preview	https://deploy-preview-37460--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[bito-code-review]

Code Review Agent Run #398826

Actionable Suggestions - 0

Additional Suggestions - 1

• superset-frontend/src/components/Chart/DrillBy/DrillByModal.test.tsx - 1

  • Test assertion scope · Line 598-598
    This test focuses on sorting behavior in table view, but the added assertion only verifies that a display toggle component renders. Per repository guidelines on test assertions, prefer verifying actual logic over mere presence checks to ensure bugs in core functionality aren't missed.

Review Details

• Files reviewed - 4 · Commit Range: 4471cc6..8a53904

  • superset-frontend/packages/superset-ui-core/src/query/types/QueryResponse.ts
  • superset-frontend/plugins/plugin-chart-table/test/testData.ts
  • superset-frontend/src/components/Chart/DrillBy/DrillByModal.test.tsx
  • superset-frontend/src/components/Chart/DrillBy/DrillByModal.tsx
• Files skipped - 0
• Tools

  • Eslint (Linter) - ✔︎ Successful
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[bito-code-review]

Code Review Agent Run #5ae808

Actionable Suggestions - 0

Review Details

• Files reviewed - 4 · Commit Range: None..None

  • superset-frontend/packages/superset-ui-core/src/query/types/QueryResponse.ts
  • superset-frontend/plugins/plugin-chart-table/test/testData.ts
  • superset-frontend/src/components/Chart/DrillBy/DrillByModal.test.tsx
  • superset-frontend/src/components/Chart/DrillBy/DrillByModal.tsx
• Files skipped - 0
• Tools

  • Eslint (Linter) - ✔︎ Successful
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by