Skip to content

Conversation

@rusackas
Copy link
Member

SUMMARY

Fixes a consistent misspelling of validationDependanciesvalidationDependencies across 3 files (5 occurrences):

  • superset-frontend/src/explore/reducers/exploreReducer.js — interface definition + 2 usages
  • superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx — control config
  • superset-frontend/plugins/plugin-chart-ag-grid-table/src/controlPanel.tsx — control config

The property name is only used internally between the control panel configs and the explore reducer, so this rename is safe. No backend references exist.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A — no UI changes.

TESTING INSTRUCTIONS

  1. Open a Table or AG Grid Table chart in Explore
  2. Toggle server_pagination on/off
  3. Verify that the row_limit control re-validates (the validation dependency still fires)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

🤖 Generated with Claude Code

…endencies`

Fixes a consistent misspelling across the reducer interface and both
table plugin control panels (5 occurrences in 3 files).

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@bito-code-review
Copy link
Contributor

bito-code-review bot commented Jan 29, 2026

Code Review Agent Run #7f8edc

Actionable Suggestions - 0
Review Details
  • Files reviewed - 3 · Commit Range: 7a9095b..7a9095b
    • superset-frontend/plugins/plugin-chart-ag-grid-table/src/controlPanel.tsx
    • superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
    • superset-frontend/src/explore/reducers/exploreReducer.js
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
    • Eslint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot bot added the explore Namespace | Anything related to Explore label Jan 29, 2026
@SBIN2010 SBIN2010 merged commit 9c0337d into master Jan 29, 2026
78 of 79 checks passed
@SBIN2010 SBIN2010 deleted the fix/typo-validationDependencies branch January 29, 2026 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

explore Namespace | Anything related to Explore plugins size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants