fix(db): Add MariaDB DDL fix for NOCYCLE syntax
#37582
Open
+81
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the MariaDB "NO CYCLE" to "NOCYCLE" DDL fix from migrations/env.py to superset/utils/database.py so it can be properly unit tested. The fix is applied early in the import chain via extensions/__init__.py.
joaopamaral
requested review from
eschutho,
geido,
kgabryje,
michael-s-molina,
rusackas and
villebro
as code owners
Contributor
Code Review Agent Run #8ad941Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
![codeant-ai-for-open-source[bot]](https://avatars.githubusercontent.com/u/151810221?s=60&v=4){kind=small}
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Author
|
All tables are created successfully in MariaDB after this change: |
Contributor
Code Review Agent Run #398bc1Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This pull request introduces a fix for a MariaDB-specific DDL syntax issue in Superset by patching SQLAlchemy's sequence creation logic. The main change ensures that when creating sequences for MariaDB, the generated SQL uses
NOCYCLEinstead of the incorrectNO CYCLEsyntax. The fix is applied early in the import chain to guarantee it takes effect throughout the application. Unit tests have also been added to verify the patch works as intended.MariaDB DDL syntax fix:
apply_mariadb_ddl_fix()tosuperset/utils/database.py, which patches SQLAlchemy'sDDLCompiler.visit_create_sequencemethod to replaceNO CYCLEwithNOCYCLEfor MariaDB dialects. This prevents SQL errors when creating sequences in MariaDB.apply_mariadb_ddl_fix()early in thesuperset/extensions/__init__.pyimport chain to ensure the fix is active before any database operations occur.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
tests/unit_tests/utils/test_database.pyto verify that the patch correctly modifies the generated SQL for MariaDB and does not affect other dialects like PostgreSQL.ADDITIONAL INFORMATION