Skip to content

fix(build): Increase ForkTsCheckerWebpackPlugin memory limit to fix OOM error #37583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hainenber merged 2 commits into from
Jan 31, 2026
Merged

fix(build): Increase ForkTsCheckerWebpackPlugin memory limit to fix OOM error #37583

hainenber merged 2 commits into from
Jan 31, 2026
+2 −2

Conversation

@michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Jan 30, 2026 •
edited
Loading

SUMMARY

Increases the memoryLimit for ForkTsCheckerWebpackPlugin from 4096 MB to 8192 MB to fix JavaScript heap out of memory errors during production builds.

The TypeScript type checker runs in a forked child process with its own memory limit separate from the main webpack process. While the main webpack process already has 8GB allocated via NODE_OPTIONS=--max_old_space_size=8192, the forked TypeScript checker was limited to 4GB, which is insufficient for the current codebase size (~14,000 modules).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

cd superset-frontend
npm run build

Before: Build fails with FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory

After: Build completes successfully

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina requested a review from a team January 30, 2026 19:43
@bito-code-review
Copy link
Contributor

bito-code-review bot commented Jan 30, 2026 •
edited
Loading

Code Review Agent Run #058487

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: b9c8cfe..b9c8cfe
    • superset-frontend/webpack.config.js
  • Files skipped - 0
  • Tools
    • Eslint (Linter) - ✔︎ Successful
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot bot added the change:frontend Requires changing the frontend label Jan 30, 2026
codeant-ai-for-open-source[bot]
codeant-ai-for-open-source bot reviewed Jan 30, 2026
View reviewed changes
sadpandajoe
sadpandajoe approved these changes Jan 30, 2026
View reviewed changes
Copy link
Member

@sadpandajoe sadpandajoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I think for my fork i just removed the check but this is the correct fix.

EnxDev
EnxDev approved these changes Jan 30, 2026
View reviewed changes
Copy link
Contributor

@EnxDev EnxDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Jan 30, 2026 •
edited
Loading

Code Review Agent Run #e088e0

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: b9c8cfe..501f543
    • superset-frontend/webpack.config.js
  • Files skipped - 0
  • Tools
    • Eslint (Linter) - ✔︎ Successful
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@hainenber hainenber merged commit 004f027 into apache:master Jan 31, 2026
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hainenber hainenber hainenber approved these changes

@sadpandajoe sadpandajoe sadpandajoe approved these changes

@EnxDev EnxDev EnxDev approved these changes

@SBIN2010 SBIN2010 SBIN2010 approved these changes

+1 more reviewer

@codeant-ai-for-open-source codeant-ai-for-open-source[bot] codeant-ai-for-open-source[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

change:frontend Requires changing the frontend size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@michael-s-molina @hainenber @sadpandajoe @EnxDev @SBIN2010