Skip to content

Conversation

@gabotorresruiz
Copy link
Contributor

@gabotorresruiz gabotorresruiz commented Feb 3, 2026

SUMMARY

Adds unit tests for the requiredFirstFilter logic in useNativeFilters hook

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  1. Run the new tests:
cd superset-frontend
npm run test superset-frontend/src/dashboard/components/DashboardBuilder/state.test.ts
  1. Verify all 7 tests pass

ADDITIONAL INFORMATION

  • Has associated issue: feat(dashboard): chart customizations modal and plugins #36062
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@bito-code-review
Copy link
Contributor

bito-code-review bot commented Feb 3, 2026

Code Review Agent Run #a6a25a

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 613791e..613791e
    • superset-frontend/src/dashboard/components/DashboardBuilder/state.test.ts
  • Files skipped - 0
  • Tools
    • Eslint (Linter) - ✔︎ Successful
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot bot added the dashboard:native-filters Related to the native filters of the Dashboard label Feb 3, 2026
@netlify
Copy link

netlify bot commented Feb 3, 2026

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 613791e
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/698221ac0aa78d0008cfdf47
😎 Deploy Preview https://deploy-preview-37640--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rusackas rusackas requested a review from sadpandajoe February 3, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dashboard:native-filters Related to the native filters of the Dashboard size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant