Skip to content

fix(save-chart): fix info icon alignment in save chart modal#37708

Open
EnxDev wants to merge 1 commit intomasterfrom
enxdev/fix/save-chart-info-icon-alignment
Open

fix(save-chart): fix info icon alignment in save chart modal#37708
EnxDev wants to merge 1 commit intomasterfrom
enxdev/fix/save-chart-info-icon-alignment

Conversation

@EnxDev
Copy link
Contributor

@EnxDev EnxDev commented Feb 5, 2026

SUMMARY

Moved InfoTooltip from being a sibling of the Input to being part of the FormItem label prop. This fixes the misalignment where the icon appeared below the label instead of inline next to "Dataset Name".

AFTER

532278340-88ee01c3-65ea-4195-9098-1a8ccef9424e

TESTING INSTRUCTIONS

  • Open a chart
  • Save a chart
  • Observe info icon alignment

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Moved InfoTooltip from being a sibling of the Input to being part
of the FormItem label prop. This fixes the misalignment where the
icon appeared below the label instead of inline next to "Dataset Name".

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@geido geido marked this pull request as ready for review February 5, 2026 18:04
@dosubot dosubot bot added change:frontend Requires changing the frontend explore:save Related to saving changes in Explore labels Feb 5, 2026
@bito-code-review
Copy link
Contributor

bito-code-review bot commented Feb 5, 2026

Code Review Agent Run #4d73ea

Actionable Suggestions - 0
Review Details
  • Files reviewed - 2 · Commit Range: 98a8390..98a8390
    • superset-frontend/src/explore/components/SaveModal.test.jsx
    • superset-frontend/src/explore/components/SaveModal.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:frontend Requires changing the frontend explore:save Related to saving changes in Explore size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants