fix: Restrict DrillDetailTable pageSizeOptions to only valid option (50)

[RamiNoodle733]

Problem

The DrillDetailTable has a fixed page size of 50 (PAGE_SIZE constant), but the pageSizeOptions was not restricted, allowing users to select 5, 15, 25, 50, 100 from a dropdown. This caused confusion as selecting other values didn't work properly since the backend always returns 50 rows per page.

Solution

Added pageSizeOptions={[PAGE_SIZE]} to the Table component in DrillDetailPane.tsx to restrict the dropdown to only show the valid option (50).

Before

Users could select page sizes other than 50, but the table would still show 50 rows, causing a mismatch between the UI and actual data.

After

The page size dropdown only shows 50 as an option, which matches the actual behavior.

Fixes #36267

[bito-code-review]

Code Review Agent Run #883552

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: 42971b5..42971b5

  • superset-frontend/src/components/Chart/DrillDetail/DrillDetailPane.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[bito-code-review]

Code Review Agent Run #7ee860

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: 289b8fb..289b8fb

  • superset-frontend/src/components/Chart/DrillDetail/DrillDetailPane.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[sadpandajoe]

I think if we want to only show 50 there needs to be a larger discussion as a whole. If you would want to fix it for the other options, then a discussion is probably not needed.