feat: Rename 'Subtotal' to 'Subvalue' in Pivot Tables#37747
feat: Rename 'Subtotal' to 'Subvalue' in Pivot Tables#37747RamiNoodle733 wants to merge 1 commit intoapache:masterfrom
Conversation
Pivot Table shows aggregated values by group. When using aggregation functions like Average, the label shows 'Subtotal' which is misleading since it's not a sum. This changes the label to 'Subvalue' to be more accurate regardless of the aggregation function used. Fixes apache#35089
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #0a4592
Actionable Suggestions - 2
-
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx - 2
- Incorrect pivot table label · Line 720-722
- Incorrect pivot table label · Line 934-934
Review Details
-
Files reviewed - 1 · Commit Range:
55d4657..55d4657- superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/TableRenderers.jsx
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
AI Code Review powered by
| > | ||
| {t('Subtotal')} | ||
| {t('Subvalue')} | ||
| </th>, |
There was a problem hiding this comment.
The change from 'Subtotal' to 'Subvalue' appears incorrect, as 'Subvalue' is not a standard term in pivot tables and doesn't align with the 'pvtSubtotalLabel' className. Pivot tables use 'Subtotal' for aggregated subgroup values, and this change could confuse users. Reverting to 'Subtotal' matches existing codebase usage and translations.
Code suggestion
Check the AI-generated fix before applying
| > | |
| {t('Subtotal')} | |
| {t('Subvalue')} | |
| </th>, | |
| > | |
| {t('Subtotal')} | |
| </th>, |
Code Review Run #0a4592
Should Bito avoid suggestions like this for future reviews? (Manage Rules)
- Yes, avoid them
| )} | ||
| > | ||
| {t('Subtotal')} | ||
| {t('Subvalue')} |
There was a problem hiding this comment.
Similar to the other location, changing 'Subtotal' to 'Subvalue' is incorrect for pivot table terminology. 'Subvalue' isn't standard and mismatches the 'pvtSubtotalLabel' className. Revert to 'Subtotal' for consistency with pivot table conventions and existing code.
Code suggestion
Check the AI-generated fix before applying
| {t('Subvalue')} | |
| {t('Subtotal')} |
Code Review Run #0a4592
Should Bito avoid suggestions like this for future reviews? (Manage Rules)
- Yes, avoid them
|
closing since there are multiple PRs for this fix. It looks like the same pr may have been opened multiple times. |
2 participants
SUMMARY
Fixes #35089
Pivot Table offers the possibility to show aggregated values by group. For example, when showing total sum of sales, the sub-group aggregations are labeled 'Subtotal'. However, when using other aggregation functions like Average, the label 'Subtotal' is misleading since it's not a sum.
This PR changes the user-facing label from 'Subtotal' to 'Subvalue' to be more accurate regardless of the aggregation function used.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A - Text label change from 'Subtotal' to 'Subvalue'
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION