feat!(deps): bump postgresql from 16 to 17#37782
feat!(deps): bump postgresql from 16 to 17#37782RealGreenDragon wants to merge 1 commit intoapache:masterfrom
Conversation
RealGreenDragon
requested review from
Antonio-RiveroMartnez,
betodealmeida,
craig-rueda,
dpgaspar,
eschutho,
geido,
hainenber,
kgabryje,
michael-s-molina,
mistercrunch,
nytai,
rusackas,
sadpandajoe and
villebro
as code owners
github-actions
bot
added
doc
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #37782 +/- ##
===========================================
+ Coverage 0 66.21% +66.21%
===========================================
Files 0 647 +647
Lines 0 49542 +49542
Branches 0 5568 +5568
===========================================
+ Hits 0 32805 +32805
- Misses 0 15435 +15435
- Partials 0 1302 +1302
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #bec56c
Actionable Suggestions - 1
-
docs/docs/configuration/configuring-superset.mdx - 1
- Inaccurate Version Listing · Line 146-146
Review Details
-
Files reviewed - 3 · Commit Range:
136ef0d..136ef0d- docs/docs/configuration/configuring-superset.mdx
- helm/superset/Chart.lock
- helm/superset/Chart.yaml
-
Files skipped - 11
- .github/workflows/superset-app-cli.yml - Reason: Filter setting
- .github/workflows/superset-applitool-cypress.yml - Reason: Filter setting
- .github/workflows/superset-e2e.yml - Reason: Filter setting
- .github/workflows/superset-playwright.yml - Reason: Filter setting
- .github/workflows/superset-python-integrationtest.yml - Reason: Filter setting
- .github/workflows/superset-python-presto-hive.yml - Reason: Filter setting
- docker-compose-image-tag.yml - Reason: Filter setting
- docker-compose-light.yml - Reason: Filter setting
- docker-compose-non-dev.yml - Reason: Filter setting
- docker-compose.yml - Reason: Filter setting
- helm/superset/README.md - Reason: Filter setting
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
AI Code Review powered by
| | [MySQL](https://www.mysql.com/) | 5.7, 8.X | | ||
| | Database Engine | Supported Versions | | ||
| | ----------------------------------------- | ---------------------------------------------- | | ||
| | [PostgreSQL](https://www.postgresql.org/) | 10.X, 11.X, 12.X, 13.X, 14.X, 15.X, 16.X, 17.X | |
There was a problem hiding this comment.
The documentation lists PostgreSQL 17.X as supported, but official Superset docs only list versions up to 16.X. While psycopg2 2.9.9 supports PostgreSQL 17, Superset's official documentation does not include it, so this addition may mislead users.
Code suggestion
Check the AI-generated fix before applying
| | [PostgreSQL](https://www.postgresql.org/) | 10.X, 11.X, 12.X, 13.X, 14.X, 15.X, 16.X, 17.X | | |
| | [PostgreSQL](https://www.postgresql.org/) | 10.X, 11.X, 12.X, 13.X, 14.X, 15.X, 16.X | |
Code Review Run #bec56c
Should Bito avoid suggestions like this for future reviews? (Manage Rules)
- Yes, avoid them
There was a problem hiding this comment.
This PR is to add PostgreSQL 17.X support.
There was a problem hiding this comment.
Yes, this PR adds PostgreSQL 17.X support by updating CI/CD workflows, Docker Compose files, documentation, and Helm charts to use PostgreSQL 17. A review comment suggests removing 17.X from the docs since official Superset documentation only lists up to 16.X.
|
Thanks for opening the PR @RealGreenDragon. There's a failed CI check with out-of-sync Chart lockfile. Can you run |
hainenber
changed the title
hainenber
added
risk:db-migration
Sorry, I missed that, |
Code Review Agent Run #1c7777Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
2 participants
SUMMARY
This PR bumps PostgreSQL image version in Dockerfile and GH workflows from postgresql:16 to postgresql:17.
Also this PR bumps Helm Chart postgresql to v16.7.27 (latest v16 release) as it uses PostgreSQL 17 (declared here).
PostgreSQL 17.0 change log: https://www.postgresql.org/docs/release/17.0/
Documentation has been updated accordingly as done in #32597 .
Inspired by discussion #33943 .
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
N/A
ADDITIONAL INFORMATION