fix(componentParent): Newly created tabs don't show up in Scoping tab

[alexandrusoare]

SUMMARY

When users create tabs or move components in dashboard edit mode, the parents array on layout items was not being updated. The parents array tracks the ancestry chain of each component (e.g., a chart inside a tab would have parents: ["ROOT_ID", "TABS_ID", "TAB_ID"]).

The updateComponentParentsList function that rebuilds these arrays was only called when saving the dashboard (via saveDashboardRequest). This meant:

1. User creates tabs → visual layout updates correctly
2. User opens filter editor → scoping tree reads stale parents arrays
3. Scoping tree shows incorrect hierarchy (charts not under tabs)
4. User refreshes page → saved data loads with correct parents → works correctly

Solution

Call updateComponentParentsList in the main layoutReducer function after any layout action that modifies the state. This ensures parents arrays are always up-to-date immediately after any layout change.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

Screen.Recording.2026-02-10.at.14.09.58.mov

AFTER

Screen.Recording.2026-02-10.at.14.07.53.mov

TESTING INSTRUCTIONS

1. Created a new dashboard with charts
2. Edited dashboard and created tabs
3. Moved charts into tabs
4. Opened filter editor → Scoping tab
5. Verified tree shows correct tab hierarchy immediately (without refresh)

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[netlify]

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	58fa17d
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/698b1b2a3a03710008be866e
😎 Deploy Preview	https://deploy-preview-37807--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[msyavuz]

LGTM!

[github-actions]

🎪 Showtime is building environment on GHA for 58fa17d

[github-actions]

🎪 Showtime deployed environment on GHA for 58fa17d

• Environment: http://16.148.104.66:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically

[bito-code-review]

Code Review Agent Run #b9fa2c

Actionable Suggestions - 0

Review Details

• Files reviewed - 2 · Commit Range: ed7895c..58fa17d

  • superset-frontend/src/dashboard/reducers/dashboardLayout.test.ts
  • superset-frontend/src/dashboard/reducers/dashboardLayout.ts
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • Eslint (Linter) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by