fix(ssh): add auto-detection support for Paramiko private key types #37811
+144
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arunodoy18
requested review from
eschutho,
geido,
kgabryje,
michael-s-molina,
rusackas and
villebro
as code owners
Contributor
|
Bito Automatic Review Failed - Technical Failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes SSH tunnel authentication failures when using modern private key formats supported by Paramiko (e.g. ED25519).
The existing implementation assumed RSA keys during private key loading, which caused valid non-RSA keys to fail during SSH tunnel initialization. Since Paramiko already supports multiple key formats, this change updates Superset to safely leverage those capabilities through automatic key type detection.
The implementation is intentionally minimal, scoped only to SSH key loading, and preserves the existing authentication flow and validation behavior. No configuration, schema, or connection model changes are introduced.
RSA-based tunnels remain fully supported, ensuring complete backward compatibility while improving support for modern SSH key standards.