fix(explore): generate correct chart export url when using legacy api#38096
Open
lucapazz wants to merge 1 commit intoapache:masterfrom
Open
fix(explore): generate correct chart export url when using legacy api#38096lucapazz wants to merge 1 commit intoapache:masterfrom
lucapazz wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Code Review Agent Run #473cecActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
When exporting data via CSV/JSON/Excel from a Time-series Table chart you get a 404 "Page not found" error.
The issue is caused by the malformed export URL, where the origin is duplicated.
This PR removes the origin from the generated URL before passing it to the
SupersetClient, which in turn adds it when making the request.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION