chore(lint): remove unused ESLint plugins after migrating rules to Oxlint#38110
chore(lint): remove unused ESLint plugins after migrating rules to Oxlint#38110
Conversation
…lint Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
Code Review Agent Run #d088dfActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
Sequence DiagramThis PR consolidates linting by moving rules to Oxlint, removes now-unnecessary ESLint plugins and related packages, and updates lockfiles so CI uses Oxlint for linting. The diagram shows the main change rollout from code edits to CI verification. sequenceDiagram
participant Developer
participant RepoConfigs as "Repo (configs & lockfiles)"
participant Oxlint
participant NPM as "Package manager & deps"
participant CI
Developer->>RepoConfigs: Edit .eslintrc.js, oxlint.json, package.json, package-lock.json
RepoConfigs->>NPM: Remove ESLint plugins & update overrides (lockfile changes)
NPM-->>RepoConfigs: Updated dependency graph
RepoConfigs->>Oxlint: Consolidated lint rules into oxlint.json
CI->>RepoConfigs: Run install & lint (uses Oxlint)
Oxlint-->>CI: Lint results (rules applied)
CI-->>Developer: Green CI (lint passes)
Generated by CodeAnt AI |
rusackas
left a comment
There was a problem hiding this comment.
Yay, we're approaching a simpler and faster linting world :D
chore(lint): remove unused ESLint plugins after migrating rules to Oxlint
SUMMARY
Since Oxlint has already implemented a majority of ESLint rules relevant to Superset's codebase, we can sunset away ESLint plugins for brevity.
I've compared and rectified any discrepancies of linting rules between ESLint plugins and Oxlint's.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Green CI as acceptance threshold
ADDITIONAL INFORMATION