Skip to content

chore(lint): remove unused ESLint plugins after migrating rules to Oxlint#38110

Merged
hainenber merged 2 commits intomasterfrom
lint/remove-unused-eslint-plugins
Mar 3, 2026
Merged

chore(lint): remove unused ESLint plugins after migrating rules to Oxlint#38110
hainenber merged 2 commits intomasterfrom
lint/remove-unused-eslint-plugins

Conversation

@hainenber
Copy link
Contributor

chore(lint): remove unused ESLint plugins after migrating rules to Oxlint

SUMMARY

Since Oxlint has already implemented a majority of ESLint rules relevant to Superset's codebase, we can sunset away ESLint plugins for brevity.

I've compared and rectified any discrepancies of linting rules between ESLint plugins and Oxlint's.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Green CI as acceptance threshold

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

…lint

Signed-off-by: hainenber <dotronghai96@gmail.com>
Signed-off-by: hainenber <dotronghai96@gmail.com>
@bito-code-review
Copy link
Contributor

bito-code-review bot commented Feb 20, 2026

Code Review Agent Run #d088df

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: c995a88..61a25b3
    • superset-frontend/.eslintrc.js
  • Files skipped - 3
    • superset-frontend/oxlint.json - Reason: Filter setting
    • superset-frontend/package-lock.json - Reason: Filter setting
    • superset-frontend/package.json - Reason: Filter setting
  • Tools
    • Eslint (Linter) - ✔︎ Successful
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot bot added the change:frontend Requires changing the frontend label Feb 20, 2026
@codeant-ai-for-open-source
Copy link
Contributor

Sequence Diagram

This PR consolidates linting by moving rules to Oxlint, removes now-unnecessary ESLint plugins and related packages, and updates lockfiles so CI uses Oxlint for linting. The diagram shows the main change rollout from code edits to CI verification.

sequenceDiagram
    participant Developer
    participant RepoConfigs as "Repo (configs & lockfiles)"
    participant Oxlint
    participant NPM as "Package manager & deps"
    participant CI

    Developer->>RepoConfigs: Edit .eslintrc.js, oxlint.json, package.json, package-lock.json
    RepoConfigs->>NPM: Remove ESLint plugins & update overrides (lockfile changes)
    NPM-->>RepoConfigs: Updated dependency graph
    RepoConfigs->>Oxlint: Consolidated lint rules into oxlint.json
    CI->>RepoConfigs: Run install & lint (uses Oxlint)
    Oxlint-->>CI: Lint results (rules applied)
    CI-->>Developer: Green CI (lint passes)
Loading

Generated by CodeAnt AI

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, we're approaching a simpler and faster linting world :D

@hainenber hainenber merged commit 1bd0546 into master Mar 3, 2026
77 of 78 checks passed
@hainenber hainenber deleted the lint/remove-unused-eslint-plugins branch March 3, 2026 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:frontend Requires changing the frontend dependencies:npm size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants