Conversation
Bumps [oxlint](https://github.com/oxc-project/oxc/tree/HEAD/npm/oxlint) from 1.48.0 to 1.49.0. - [Release notes](https://github.com/oxc-project/oxc/releases) - [Changelog](https://github.com/oxc-project/oxc/blob/main/npm/oxlint/CHANGELOG.md) - [Commits](https://github.com/oxc-project/oxc/commits/oxlint_v1.49.0/npm/oxlint) --- updated-dependencies: - dependency-name: oxlint dependency-version: 1.49.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
Bito Automatic Review Skipped - Files Excluded |
There was a problem hiding this comment.
Code Review Agent Run #ef69a1
Actionable Suggestions - 1
-
superset-frontend/plugins/legacy-plugin-chart-rose/src/Rose.ts - 1
- Invalid oxlint disable syntax · Line 20-20
Filtered by Review Rules
Bito filtered these suggestions based on rules created automatically for your feedback. Manage rules.
-
superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopoverTrigger.tsx - 2
- Type Safety: Replace 'any' with Dataset · Line 55-55
- Type Safety: Type useSelector state · Line 214-214
Review Details
-
Files reviewed - 12 · Commit Range:
07fddf2..9b1f86d- superset-frontend/packages/superset-core/src/ui/theme/utils/themeUtils.ts
- superset-frontend/plugins/legacy-plugin-chart-rose/src/Rose.ts
- superset-frontend/plugins/plugin-chart-ag-grid-table/src/AgGridTable/components/CustomPopover.tsx
- superset-frontend/plugins/plugin-chart-ag-grid-table/src/utils/agGridFilterConverter.ts
- superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/transformProps.test.ts
- superset-frontend/plugins/plugin-chart-table/src/transformProps.ts
- superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.tsx
- superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopoverTrigger.tsx
- superset-frontend/src/explore/components/controls/MetricControl/AdhocMetric.ts
- superset-frontend/src/features/alerts/AlertReportModal.tsx
- superset-frontend/src/features/databases/DatabaseModal/index.tsx
- superset-frontend/src/pages/UserInfo/index.tsx
-
Files skipped - 2
- superset-frontend/package-lock.json - Reason: Filter setting
- superset-frontend/package.json - Reason: Filter setting
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- Eslint (Linter) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
| */ | ||
| // @ts-nocheck | ||
| /* eslint no-use-before-define: ["error", { "functions": false }] */ | ||
| /* oxlint-disable no-use-before-define: ["error", { "functions": false }] */ |
There was a problem hiding this comment.
The updated comment uses invalid syntax for oxlint, which doesn't support inline rule configuration with options like ESLint does. This could cause linting failures if the file violates the no-use-before-define rule.
Code suggestion
Check the AI-generated fix before applying
--- superset-frontend/plugins/legacy-plugin-chart-rose/src/Rose.ts
+++ superset-frontend/plugins/legacy-plugin-chart-rose/src/Rose.ts
@@ -20,1 +20,1 @@
-/* oxlint-disable no-use-before-define: ["error", { "functions": false }] */
+/* oxlint-disable no-use-before-define */
Code Review Run #ef69a1
Should Bito avoid suggestions like this for future reviews? (Manage Rules)
- Yes, avoid them
Bumps oxlint from 1.48.0 to 1.49.0.
Release notes
Sourced from oxlint's releases.
... (truncated)
Commits
3f0d1ddrelease(apps): oxlint v1.49.0 && oxfmt v0.34.0 (#19553)c34263cchore(oxlint): bump min tsgolint version to 0.14.1 (#19554)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)