fix(charts): improve minor gridline visibility in dark themes#38371
Merged
michael-s-molina merged 1 commit intoapache:masterfrom Mar 4, 2026
Merged
Conversation
Minor tick gridlines were using ECharts default colors, making them overly bright and prominent in dark themes. This change applies the theme's colorBorderSecondary token to minor gridlines, making them appropriately subtle while maintaining visual hierarchy. Fixes apache#37344 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Code Review Agent Run #ce0380Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
michael-s-molina
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #37344 - Minor tick gridlines were overly bright and prominent in dark themes.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
The issue reporter provided screenshots showing overly bright minor gridlines in dark theme:
DESCRIPTION OF CHANGE
Minor tick gridlines were using ECharts default colors instead of theme-aware colors, making them overly bright and visually dominant in dark themes. This change applies the theme's
colorBorderSecondarytoken to minor gridlines for both x and y axes.Changes:
minorSplitLineconfiguration toxAxisthememinorSplitLineconfiguration toyAxisthemecolorBorderSecondarytoken for appropriate subtletyThis ensures minor gridlines maintain proper visual hierarchy (less prominent than major gridlines) while being theme-aware across both light and dark modes.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION