fix(mcp): honor target_tab parameter when adding charts to tabbed dashboards

[aminghadersohi]

SUMMARY

When adding charts to a dashboard that uses tabs via the add_chart_to_existing_dashboard MCP tool, the target_tab parameter was accepted without error but completely ignored. Charts were always placed in the first tab or under GRID_ID at the root level, where they become invisible ghost entries — registered in the dashboard metadata but never rendered in the UI.

Root cause: _find_tab_insert_target() always returned the first TAB child and the request.target_tab value was never passed to it.

Fix: _find_tab_insert_target() now accepts an optional target_tab parameter and resolves it by matching against the tab display name (meta.text) or the raw component ID. When no match is found it falls back to the first tab to preserve backward compatibility.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A — backend logic change, no UI modifications.

TESTING INSTRUCTIONS

1. Create a dashboard with multiple tabs (e.g., "Activity Metrics", "Customers")
2. Call add_chart_to_existing_dashboard with target_tab set to the second tab's name
3. Verify the chart appears inside the specified tab (not the first tab, and not invisible under GRID_ID)
4. Call without target_tab — chart should still land in the first tab (backward compat)

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #1ddbaa

Actionable Suggestions - 0

Review Details

• Files reviewed - 2 · Commit Range: 4f1ef5a..4f1ef5a

  • superset/mcp_service/dashboard/tool/add_chart_to_existing_dashboard.py
  • tests/unit_tests/mcp_service/dashboard/tool/test_dashboard_generation.py
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • MyPy (Static Code Analysis) - ✔︎ Successful
  • Astral Ruff (Static Code Analysis) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.08%. Comparing base (983b633) to head (4f1ef5a).
⚠️ Report is 22 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #38372      +/-   ##
==========================================
+ Coverage   64.30%   65.08%   +0.78%     
==========================================
  Files        1811     2484     +673     
  Lines       71557   124131   +52574     
  Branches    22810    28845    +6035     
==========================================
+ Hits        46015    80792   +34777     
- Misses      25542    41923   +16381     
- Partials        0     1416    +1416     

Flag	Coverage Δ
hive	41.28% <ø> (?)
mysql	64.31% <ø> (?)
postgres	64.38% <ø> (?)
presto	41.30% <ø> (?)
python	66.13% <ø> (?)
sqlite	63.98% <ø> (?)
unit	100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[aminghadersohi]

Reopening with a clean branch name.