chore(playwright): Using warning for timeouts

[Antonio-RiveroMartnez]

SUMMARY

Playwright should use the same log level as selenium does for timeouts, this way we reduce noisy traces marked as errors too.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #a30d56

Actionable Suggestions - 0

Additional Suggestions - 1

• superset/utils/webdriver.py - 1

  • Inconsistent exception logging · Line 306-306
    This change from logger.exception to logger.warning creates inconsistency with the other three identical PlaywrightTimeout exception handlers in the get_screenshot method (lines 263, 283, 293), which all use logger.exception. Since the exception is being re-raised, logger.exception is appropriate to include traceback information for debugging. If the intent was to reduce log verbosity, consider a uniform change across all timeout handlers.
    Code suggestion

     @@ -303,1 +303,1 @@
    -                    logger.warning(
    +                    logger.exception(

Review Details

• Files reviewed - 1 · Commit Range: acdbbed..acdbbed

  • superset/utils/webdriver.py
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • MyPy (Static Code Analysis) - ✔︎ Successful
  • Astral Ruff (Static Code Analysis) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.97%. Comparing base (880cab5) to head (03778a1).

Files with missing lines	Patch %	Lines
superset/utils/webdriver.py	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #38441      +/-   ##
==========================================
+ Coverage   64.80%   64.97%   +0.16%     
==========================================
  Files        1815     2515     +700     
  Lines       71912   126733   +54821     
  Branches    22915    29228    +6313     
==========================================
+ Hits        46606    82343   +35737     
- Misses      25306    42961   +17655     
- Partials        0     1429    +1429     

Flag	Coverage Δ
hive	41.64% <0.00%> (?)
mysql	63.41% <0.00%> (?)
postgres	63.48% <0.00%> (?)
presto	41.66% <0.00%> (?)
python	65.16% <0.00%> (?)
sqlite	63.10% <0.00%> (?)
unit	100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.