refactor(core): reorganize superset-core packages into feature-based structure#38448
Merged
michael-s-molina merged 6 commits intoapache:masterfrom Mar 5, 2026
Merged
Conversation
f3b4a75 to
591dcfe
Compare
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #38448 +/- ##
==========================================
+ Coverage 64.82% 65.08% +0.26%
==========================================
Files 1815 2520 +705
Lines 71917 127270 +55353
Branches 22915 29228 +6313
==========================================
+ Hits 46618 82834 +36216
- Misses 25299 43007 +17708
- Partials 0 1429 +1429
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
villebro
approved these changes
Mar 5, 2026
Member
villebro
left a comment
There was a problem hiding this comment.
That's a ridiculous number of changed files 😆 LGTM
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
SUMMARY
Reorganizes both the Python (
superset_core) and TypeScript (superset-core) packages from layer-based containers into a feature-based structure. This is a clean break — no backward-compatible shims.Note for reviewers
The diff is large because all consumers were updated to the new import paths. The substantive change is the reorganization of the
superset-corepackages themselves — everything else is mechanical import updates.Motivation
This follows the same principles as SIP-61, which reorganized the main
superset-frontend/src/from layer-based directories into feature-based ones. We apply the same thinking here tosuperset_coreandsuperset-core.Both packages previously grouped code by layer (
api/,ui/) rather than by feature. Theapi/layer bundled unrelated concerns: query execution types, async task infrastructure, MCP tool decorators, REST API utilities, and shared models — all in the same directory. Theui/layer similarly co-located theme tokens, translation utilities, and UI components. This made it hard to understand what a given subpackage was for, and meant every consumer had to know which single file a symbol came from rather than which domain.Python (
superset_core)TypeScript (
superset-core/src)TESTING INSTRUCTIONS
pre-commit run— all hooks should pass.npm run plugins:buildinsidesuperset-frontend/— all 23 packages should compile cleanly.ADDITIONAL INFORMATION
CodeAnt-AI Description
Reorganize and expose a feature-based core package with a complete theming and translation surface
What Changed
Impact
✅ Consistent theming across the app (single Theme API and provider)✅ Reliable dark-mode detection and theme serialization for persistence✅ Simplified, feature-focused import paths for theme and translation💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.