feat(native-filters): add configurable LIKE/ILIKE operators to Select filter by endimonan · Pull Request #38470 · apache/superset

endimonan · 2026-03-06T12:04:27Z

SUMMARY

Adds a configurable "Match type" option to the native Select (Value) dashboard filter, enabling partial text matching via ILIKE operators in addition to the default exact match (IN).

This addresses a community request (Discussion #25358) where users need to filter by partial text (e.g., typing "Jen" to find "Jennifer", "Jenna", "Jenny") but are limited to selecting exact values from a dropdown.

New "Match type" options in filter configuration:

Exact match (IN) — default, preserves existing behavior
Contains text (ILIKE %x%) — matches anywhere in the string
Starts with (ILIKE x%) — matches from the beginning
Ends with (ILIKE %x) — matches at the end

When an ILIKE operator is selected, the filter renders a free-text Input field (with debounce) instead of the dropdown Select. Inverse selection uses NOT ILIKE accordingly.

Includes a performance warning tooltip since ILIKE queries may not leverage indexes on large datasets.

Files changed (9):

types.ts — new SelectFilterOperatorType enum + operatorType in form data
controlPanel.ts — new "Match type" SelectControl with 4 options
utils.ts — getSelectExtraFormData() now supports ILIKE/NOT ILIKE with wildcards
SelectFilterPlugin.tsx — conditional Input vs Select rendering based on operator
Operator.ts — added NOT ILIKE to BINARY_OPERATORS
FiltersConfigForm.tsx — custom rendering of Match type dropdown in config modal
getControlItemsMap.tsx — excludes operatorType from generic checkbox loop

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

Open any dashboard with a native Select filter on a text column (e.g., name on birth_names)
On the filter bar, click the gear/settings icon to open the filter configuration modal
Select an existing filter (or create a new one on a text column)
In the configuration modal, find the new "Match type" dropdown under the filter settings
Change from "Exact match (IN)" to "Contains text (ILIKE %x%)"
Save the filter configuration
The filter should now show a text input instead of a dropdown
Type a partial value (e.g., "Jen") — the dashboard charts should update showing all matching records (Jennifer, Jenna, etc.)
Verify "Starts with" and "Ends with" modes work similarly
Verify switching back to "Exact match" restores the original Select dropdown
Verify inverse selection (is/is not) works correctly with ILIKE operators

ADDITIONAL INFORMATION

… filter Adds a "Match type" dropdown to the Select (Value) filter configuration, allowing filter creators to choose between exact matching (IN) and partial text matching via ILIKE with configurable wildcard patterns: - Exact match (IN) - default, preserves existing behavior - Contains text (ILIKE %x%) - matches anywhere in the string - Starts with (ILIKE x%) - matches from the beginning - Ends with (ILIKE %x) - matches at the end When an ILIKE operator is selected, the filter renders a free-text Input field instead of the dropdown Select, with debounced updates. Inverse selection uses NOT ILIKE accordingly. Includes a performance warning tooltip since ILIKE queries may be slow on large datasets as they cannot leverage indexes effectively. Ref: apache#25358

richardfogaca · 2026-03-06T12:42:08Z

Hey @endimonan this is awesome, great job and congratulations on your first Superset PR! 🥳

bito-code-review

Code Review Agent Run #45eb5e

Actionable Suggestions - 1

superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx - 1
- Uncontrolled input inconsistency · Line 550-565

Additional Suggestions - 1

superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx - 1
- Missing Input Ref · Line 551-565
  
  The Input lacks ref={inputRef} unlike the Select, which may break programmatic focus if inputRef is used elsewhere.
  Code suggestion
  @@ -574,2 +574,3 @@ - disabled={isDisabled} - /> + disabled={isDisabled} + ref={inputRef} + />

Review Details

Files reviewed - 9 · Commit Range: 006de66..006de66
- superset-frontend/packages/superset-ui-core/src/query/types/Operator.ts
- superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
- superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/getControlItemsMap.tsx
- superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx
- superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
- superset-frontend/src/filters/components/Select/buildQuery.test.ts
- superset-frontend/src/filters/components/Select/controlPanel.ts
- superset-frontend/src/filters/components/Select/types.ts
- superset-frontend/src/filters/utils.ts
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
- Eslint (Linter) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

bito-code-review · 2026-03-06T13:26:36Z

superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx

+          {isLikeOperator ? (
+            <Input
+              allowClear
+              placeholder={likeInputPlaceholder}
+              defaultValue={
+                filterState.value?.[0] != null
+                  ? String(filterState.value[0])
+                  : undefined
+              }
+              onChange={handleLikeInputChange}
+              onFocus={setFocusedFilter}
+              onBlur={unsetFocusedFilter}
+              onMouseEnter={setHoveredFilter}
+              onMouseLeave={unsetHoveredFilter}
+              disabled={isDisabled}
+            />


Uncontrolled input inconsistency

The Input component uses defaultValue, making it uncontrolled and inconsistent with the controlled Select. If filterState.value changes externally (e.g., filter reset), the input won't update, potentially showing stale data. This differs from Select, which reflects changes immediately. To fix, add a local state for the input value and make the Input controlled.

Code Review Run #45eb5e

Should Bito avoid suggestions like this for future reviews? (Manage Rules)

Yes, avoid them

I think the bot might have a point here, can you please double check?

Yes, the suggestion is valid — the Input uses defaultValue, making it uncontrolled and inconsistent with the controlled Select, which could lead to stale data if filterState.value changes externally. Adding local state to control the Input would ensure it updates properly.

richardfogaca · 2026-03-06T17:41:51Z

superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx

+  const setDataMaskMock = jest.fn();
+
+  render(
+    // @ts-expect-error


is there a way to remove these and properly type?

bito-code-review · 2026-03-06T17:42:43Z

Yes, you can remove @ts-expect-error by properly typing the test props, such as defining interfaces for the mock data or using type assertions. For example, cast the props to the expected type or extend the types to include the test-specific fields.

richardfogaca · 2026-03-06T17:51:33Z

superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx

+    operatorType = SelectFilterOperatorType.Exact,
  } = formData;

+  const isLikeOperator = operatorType !== SelectFilterOperatorType.Exact;


Can we restrict the new ILIKE modes to string columns? As written, any non-Exact operator flips to text input + ILIKE/NOT ILIKE, which may not be valid for non-text columns on all engines

richardfogaca · 2026-03-06T17:52:44Z

superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx

+            <Input
+              allowClear
+              placeholder={likeInputPlaceholder}
+              defaultValue={


I think this input should probably be controlled instead of using defaultValue. In LIKE mode, filter state can change from clear-all/defaults/parent updates, and the visible text could get out of sync with the actual dataMask

richardfogaca · 2026-03-06T17:53:24Z

...ashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx

+    filterToEdit?.controlValues?.operatorType ??
+    SelectFilterOperatorType.Exact;
+
+  const onOperatorTypeChanged = (value: SelectFilterOperatorType) => {


One edge case here: if a user already has Exact selections and then switches to a LIKE mode, we only use the first selected value. It may be safer to clear/reset the filter value when operatorType changes

richardfogaca · 2026-03-06T17:56:10Z

...ashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx

+                                </>
+                              }
+                            >
+                              <Select


The Match type options are duplicated here and in the Select filter control config. It would be better to share one source of truth to avoid drift

richardfogaca · 2026-03-06T17:58:41Z

The added tests are helpful, especially around rendering and extra form data generation. I think one more test would strengthen this: simulate typing into the new LIKE input and assert that setDataMask receives the expected ILIKE / NOT ILIKE payload. A clear-all or default-value sync test for LIKE mode would also help cover the new state-management path
Also could you take a look at the bot suggestion please?

pull-request-size bot added the size/XL label Mar 6, 2026

github-actions bot added the packages label Mar 6, 2026

endimonan force-pushed the feat/filter-ilike-operator branch from 16cab98 to 006de66 Compare March 6, 2026 12:10

richardfogaca self-requested a review March 6, 2026 12:39

endimonan marked this pull request as ready for review March 6, 2026 12:50

dosubot bot added the dashboard:native-filters Related to the native filters of the Dashboard label Mar 6, 2026

bito-code-review bot reviewed Mar 6, 2026

View reviewed changes

richardfogaca requested review from EnxDev, amaannawab923, geido, kgabryje and rusackas March 6, 2026 17:35

richardfogaca reviewed Mar 6, 2026

View reviewed changes

sadpandajoe requested a review from michael-s-molina March 6, 2026 18:34

richardfogaca assigned endimonan Mar 6, 2026

richardfogaca linked an issue Mar 6, 2026 that may be closed by this pull request

Enabling partial text matches in dashboard filters. #38483

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(native-filters): add configurable LIKE/ILIKE operators to Select filter#38470

feat(native-filters): add configurable LIKE/ILIKE operators to Select filter#38470
endimonan wants to merge 1 commit intoapache:masterfrom
endimonan:feat/filter-ilike-operator

endimonan commented Mar 6, 2026 •

edited by richardfogaca

Loading

Uh oh!

richardfogaca commented Mar 6, 2026

Uh oh!

bito-code-review bot left a comment •

edited

Loading

Uh oh!

bito-code-review bot Mar 6, 2026

Uh oh!

richardfogaca Mar 6, 2026

Uh oh!

bito-code-review bot Mar 6, 2026

Uh oh!

richardfogaca Mar 6, 2026

Uh oh!

bito-code-review bot commented Mar 6, 2026

Uh oh!

richardfogaca Mar 6, 2026

Uh oh!

richardfogaca Mar 6, 2026

Uh oh!

richardfogaca Mar 6, 2026

Uh oh!

richardfogaca Mar 6, 2026

Uh oh!

richardfogaca commented Mar 6, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

endimonan commented Mar 6, 2026 • edited by richardfogaca Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

richardfogaca commented Mar 6, 2026

Uh oh!

bito-code-review bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Code Review Agent Run #45eb5e

Uh oh!

bito-code-review bot Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

richardfogaca Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

bito-code-review bot Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

richardfogaca Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

bito-code-review bot commented Mar 6, 2026

Uh oh!

richardfogaca Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

richardfogaca Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

richardfogaca Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

richardfogaca Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

richardfogaca commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

endimonan commented Mar 6, 2026 •

edited by richardfogaca

Loading

bito-code-review bot left a comment •

edited

Loading

richardfogaca commented Mar 6, 2026 •

edited

Loading