fix(deckgl): polygon chart not rendering when boundary column contains nested geometry JSON#38595
fix(deckgl): polygon chart not rendering when boundary column contains nested geometry JSON#38595
Conversation
Code Review Agent Run #5a70b0Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
codeant-ai-for-open-source
bot
added
the
size:L
Sequence DiagramThis PR updates polygon data transformation to support boundary JSON where coordinates are nested under a geometry field. The fallback prevents rows from being dropped and allows deckgl polygon maps to render correctly for affected datasets. sequenceDiagram
participant User
participant PolygonChart
participant TransformProps
participant BoundaryJSON
participant DeckGL
User->>PolygonChart: Open polygon chart
PolygonChart->>TransformProps: Transform query rows into polygon features
TransformProps->>BoundaryJSON: Parse boundary JSON
alt Top level coordinates exist
BoundaryJSON-->>TransformProps: Return coordinates
else Nested geometry coordinates exist
BoundaryJSON-->>TransformProps: Return geometry coordinates
end
TransformProps->>DeckGL: Build polygon features
DeckGL-->>User: Render polygons on map
Generated by CodeAnt AI |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Polygon/transformProps.test.ts
Outdated
Show resolved
Hide resolved
|
The existing test in transformProps.test.ts has been modified in this PR to change the 'geom' data from a plain array to a GeoJSON Polygon object. This aligns with added support for GeoJSON formats, and two new tests were added for Feature and Geometry variants. No further modifications appear needed based on the diff. |
|
@EnxDev This workflow is deprecated! Please use the new Superset Showtime system instead:
Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments |
|
@EnxDev Ephemeral environment spinning up at http://34.215.30.164:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup. |
Code Review Agent Run #108ec9Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
EnxDev
added
hold:testing!
…s nested geometry JSON (apache#38595)
2 participants
User description
SUMMARY
The deck.gl Polygon chart was rendering a blank map when the polygon column contained JSON data with coordinates nested inside a
geometrykey.The JSON parser only checked for top-level coordinates.
When the key was absent, the row was silently dropped, resulting in an empty features array and a blank map.
This affected the boundary_precipitation dataset where every row uses this format.
The fix adds a fallback to extract coordinates from
parsed.geometry.coordinateswhenparsed.coordinatesis not present.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Recording.2026-03-12.112449.mp4
Recording.2026-03-12.095311.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
CodeAnt-AI Description
Render polygon charts when boundary column contains nested or GeoJSON geometry
What Changed
Impact
✅ Fewer blank polygon maps for datasets with nested geometry JSON✅ Polygon charts accept GeoJSON Feature/Geometry inputs✅ Clearer test coverage for polygon input formats💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.