Skip to content

style(metadata-bar): use bold font weight for metadata bar title #38608

Merged
michael-s-molina merged 2 commits intoapache:masterfrom
luizotavio32:metadata-bar-fontweight-fix
Mar 13, 2026
Merged

style(metadata-bar): use bold font weight for metadata bar title #38608
michael-s-molina merged 2 commits intoapache:masterfrom
luizotavio32:metadata-bar-fontweight-fix

Conversation

@luizotavio32
Copy link
Contributor

@luizotavio32 luizotavio32 commented Mar 12, 2026

User description

SUMMARY

Uses a bolder font for the MetadataBar tooltip Header component.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
image

AFTER:
image

TESTING INSTRUCTIONS

  1. Navigate to any chart or dashboard and hover over the metadata bar.
  2. Confirm the metadata bar header/title text appears visually bold.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CodeAnt-AI Description

Make metadata bar header use bold font weight

What Changed

  • Metadata bar header now uses the theme's bold weight token instead of the legacy/undefined strong token
  • Metadata bar title renders visually bold and consistent across themes where the previous token could be missing

Impact

✅ Bold metadata titles
✅ Consistent header weight across themes
✅ Improved metadata header readability

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

@codeant-ai-for-open-source codeant-ai-for-open-source bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Mar 12, 2026
@codeant-ai-for-open-source
Copy link
Contributor

Sequence Diagram

This PR updates metadata title rendering to use the CSS bold keyword directly instead of a theme font weight token. The change removes theme dependency so the header consistently appears bold across themes.

sequenceDiagram
    participant User
    participant MetadataBar
    participant Theme
    participant Browser

    User->>MetadataBar: Open view with metadata section
    MetadataBar->>Theme: Read theme values for component styles
    MetadataBar->>Browser: Apply title style with font weight bold
    Browser-->>User: Render metadata title in bold consistently
Loading

Generated by CodeAnt AI

@dosubot dosubot bot added change:frontend Requires changing the frontend global:theming Related to theming Superset labels Mar 12, 2026
@netlify
Copy link

netlify bot commented Mar 12, 2026

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit b0212dc
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/69b2f63c7c646a00079393ed
😎 Deploy Preview https://deploy-preview-38608--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@bito-code-review bito-code-review bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Agent Run #133ad7

Actionable Suggestions - 1
  • superset-frontend/packages/superset-ui-core/src/components/MetadataBar/ContentConfig.tsx - 1
Review Details
  • Files reviewed - 1 · Commit Range: b0212dc..b0212dc
    • superset-frontend/packages/superset-ui-core/src/components/MetadataBar/ContentConfig.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@codeant-ai-for-open-source codeant-ai-for-open-source bot added size:XS This PR changes 0-9 lines, ignoring generated files and removed size:XS This PR changes 0-9 lines, ignoring generated files labels Mar 12, 2026
@codeant-ai-for-open-source
Copy link
Contributor

Sequence Diagram

This PR updates the metadata bar tooltip header styling to use the theme bold font weight token. The main flow remains the same, but header rendering now consistently resolves to a bold weight across themes.

sequenceDiagram
    participant User
    participant MetadataBar
    participant Theme

    User->>MetadataBar: Hover over metadata bar
    MetadataBar->>Theme: Resolve header font weight token
    Theme-->>MetadataBar: Return fontWeightBold
    MetadataBar-->>User: Show tooltip header in bold text
Loading

Generated by CodeAnt AI

@luizotavio32 luizotavio32 changed the title Title: style(metadata-bar): use bold font weight for metadata bar title style(metadata-bar): use bold font weight for metadata bar title Mar 12, 2026
@bito-code-review
Copy link
Contributor

bito-code-review bot commented Mar 12, 2026

Code Review Agent Run #6d67f1

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: b0212dc..3c74467
    • superset-frontend/packages/superset-ui-core/src/components/MetadataBar/ContentConfig.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@michael-s-molina michael-s-molina merged commit e8061a9 into apache:master Mar 13, 2026
80 of 84 checks passed
michael-s-molina pushed a commit that referenced this pull request Mar 17, 2026
@michael-s-molina michael-s-molina moved this from Done to Cherried in Superset 6.1.0 Release Bugs Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:frontend Requires changing the frontend global:theming Related to theming Superset packages size/XS size:XS This PR changes 0-9 lines, ignoring generated files

Projects

Development

Successfully merging this pull request may close these issues.

6.1.0rc1 - Font boldness from MetadataBar header is nearly the same as the text

2 participants