refactor(mcp): use serialize_user_object in get_instance_info

superset/mcp_service/system/tool/get_instance_info.py

@@ -30,7 +30,7 @@
 from superset.mcp_service.system.schemas import (
     GetSupersetInstanceInfoRequest,
     InstanceInfo,
-    UserInfo,
+    serialize_user_object,
 )
 from superset.mcp_service.system.system_utils import (
     calculate_dashboard_breakdown,
@@ -110,24 +110,7 @@ def get_instance_info(
         # Attach the authenticated user's identity to the response
         user = getattr(g, "user", None)
         if user is not None:
-            raw_roles = getattr(user, "roles", None)
-            user_roles = []
-            if raw_roles is not None:
-                try:
-                    user_roles = [
-                        role.name for role in raw_roles if hasattr(role, "name")
-                    ]
-                except TypeError:
-                    logger.debug("Could not iterate user.roles: %s", type(raw_roles))
-                    user_roles = []
-            result.current_user = UserInfo(
-                id=getattr(user, "id", None),
-                username=getattr(user, "username", None),
-                first_name=getattr(user, "first_name", None),
-                last_name=getattr(user, "last_name", None),
-                email=getattr(user, "email", None),
-                roles=user_roles,
-            )
+            result.current_user = serialize_user_object(user)
 
         return result
 

tests/unit_tests/mcp_service/system/tool/test_get_current_user.py

@@ -221,6 +221,7 @@ async def test_get_instance_info_returns_current_user(self, mcp_server):
         mock_g_user.first_name = "Sophie"
         mock_g_user.last_name = "Beaumont"
         mock_g_user.email = "sophie@preset.io"
+        mock_g_user.active = True
         mock_g_user.roles = [mock_role]
 
         with (