fix(extensions): fix gitignore template and bump version#38614
fix(extensions): fix gitignore template and bump version#38614michael-s-molina merged 1 commit intoapache:masterfrom
Conversation
Code Review Agent Run #9ad6f4Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
Sequence DiagramThis PR fixes extension scaffolding by renaming the template file so it is included in package builds, while keeping the generated output as sequenceDiagram
participant Developer
participant BuildSystem
participant TemplateFiles
participant CLI
participant NewExtension
Developer->>BuildSystem: Build extensions cli package
BuildSystem->>TemplateFiles: Include gitignore.j2 in source bundle
Developer->>CLI: Run extension init
CLI->>TemplateFiles: Load and render gitignore.j2
CLI->>NewExtension: Write .gitignore file
CLI-->>Developer: Extension scaffold created successfully
Generated by CodeAnt AI |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #38614 +/- ##
==========================================
+ Coverage 65.01% 65.19% +0.17%
==========================================
Files 1817 1822 +5
Lines 72318 72839 +521
Branches 23032 23032
==========================================
+ Hits 47016 47484 +468
- Misses 25302 25355 +53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
michael-s-molina
left a comment
There was a problem hiding this comment.
Thanks @villebro! I'll update the PyPI package when cutting Superset 6.1.0 RC2 as we might have other fixes before then.
(cherry picked from commit f538326)
User description
SUMMARY
Currently the
.gitignore.j2template was being ignored by the Python builder, likely due to security constraints (makes sense). I felt it's a better idea to just remove the leading dot from the template file than go messing about with the security configs (the generated file keeps the leading dot, ofc). Since we already have a test that ensures the creation of.gitignore, no tests needed to be updated.TESTING INSTRUCTIONS
python -m build, unpack the generated source bundle and verify thatgitignore.j2is included in the bundle<publisher>/<name>/.gitignoreactually gets created. Note: it's hidden by default! so you need do dols -aor similarADDITIONAL INFORMATION
CodeAnt-AI Description
Include gitignore template in packaged CLI and generate .gitignore when scaffolding; bump CLI version
What Changed
Impact
✅ Scaffolded extensions include .gitignore✅ New projects start with common ignore patterns (Node, Python, IDE, OS, env, logs)✅ Packaged CLI contains the gitignore template for reliable scaffolding💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.