Skip to content

fix(ag-grid-table): fix failing buildQuery test expectation#38636

Merged
hainenber merged 1 commit intomasterfrom
fix/ag-grid-test-fix
Mar 13, 2026
Merged

fix(ag-grid-table): fix failing buildQuery test expectation#38636
hainenber merged 1 commit intomasterfrom
fix/ag-grid-test-fix

Conversation

@amaannawab923
Copy link
Contributor

Update test to match actual code behavior - simple column names are not quoted with double quotes in resolved SQL expressions.

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Update test to match actual code behavior - simple column names
are not quoted with double quotes in resolved SQL expressions.
@bito-code-review
Copy link
Contributor

bito-code-review bot commented Mar 13, 2026

Code Review Agent Run #c77114

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 86df04d..86df04d
    • superset-frontend/plugins/plugin-chart-ag-grid-table/test/buildQuery.test.ts
  • Files skipped - 0
  • Tools
    • Eslint (Linter) - ✔︎ Successful
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@hainenber hainenber merged commit 6e7d6a8 into master Mar 13, 2026
72 of 73 checks passed
@hainenber hainenber deleted the fix/ag-grid-test-fix branch March 13, 2026 17:59
michael-s-molina pushed a commit that referenced this pull request Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants