Skip to content

fix(popup): Dropdown popup width doesn't match input width when tags collapse in oneLine mode#39136

Open
alexandrusoare wants to merge 3 commits intomasterfrom
alexandrusoare/fix/dropdown-width
Open

fix(popup): Dropdown popup width doesn't match input width when tags collapse in oneLine mode#39136
alexandrusoare wants to merge 3 commits intomasterfrom
alexandrusoare/fix/dropdown-width

Conversation

@alexandrusoare
Copy link
Copy Markdown
Contributor

SUMMARY

In horizontal filter bar (oneLine mode), when a multi-select filter has selected items, the dropdown popup width doesn't match the input width after it opens.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

Screen.Recording.2026-04-06.at.14.12.21.mov

AFTER

Screen.Recording.2026-04-06.at.14.10.44.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review bot commented Apr 6, 2026

Code Review Agent Run #709e75

Actionable Suggestions - 0
Review Details
  • Files reviewed - 2 · Commit Range: 97d2730..97d2730
    • superset-frontend/packages/superset-ui-core/src/components/Select/Select.test.tsx
    • superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@dosubot dosubot bot added the change:frontend Requires changing the frontend label Apr 6, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.56%. Comparing base (d796543) to head (e06b619).
⚠️ Report is 46 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #39136      +/-   ##
==========================================
+ Coverage   64.52%   64.56%   +0.03%     
==========================================
  Files        2536     2536              
  Lines      131208   131139      -69     
  Branches    30457    30450       -7     
==========================================
+ Hits        84661    84666       +5     
+ Misses      45084    45010      -74     
  Partials     1463     1463              
Flag Coverage Δ
javascript 66.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review bot commented Apr 6, 2026

Code Review Agent Run #8a192b

Actionable Suggestions - 0
Review Details
  • Files reviewed - 1 · Commit Range: 97d2730..e06b619
    • superset-frontend/packages/superset-ui-core/src/components/Select/Select.test.tsx
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

@sadpandajoe sadpandajoe added review:checkpoint Last PR reviewed during the daily review standup 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR labels Apr 7, 2026
@github-actions github-actions bot added 🎪 e06b619 🚦 building Environment e06b619 status: building 🎪 e06b619 📅 2026-04-09T16-21 Environment e06b619 created at 2026-04-09T16-21 🎪 e06b619 🤡 sadpandajoe Environment e06b619 requested by sadpandajoe 🎪 ⌛ 48h Environment expires after 48 hours (default) and removed 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR labels Apr 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

🎪 Showtime is building environment on GHA for e06b619

@github-actions github-actions bot added 🎪 e06b619 🚦 deploying Environment e06b619 status: deploying 🎪 e06b619 🚦 running Environment e06b619 status: running 🎪 🎯 e06b619 Active environment pointer - e06b619 is receiving traffic 🎪 e06b619 🌐 34.221.17.37:8080 Environment e06b619 URL: http://34.221.17.37:8080 (click to visit) and removed 🎪 e06b619 🚦 building Environment e06b619 status: building 🎪 e06b619 🚦 deploying Environment e06b619 status: deploying 🎪 e06b619 🚦 running Environment e06b619 status: running 🎪 🎯 e06b619 Active environment pointer - e06b619 is receiving traffic labels Apr 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

🎪 Showtime deployed environment on GHA for e06b619

Environment: http://34.221.17.37:8080 (admin/admin)
Lifetime: 48h auto-cleanup
Updates: New commits create fresh environments automatically

@michaelmorera-preset
Copy link
Copy Markdown

The application is working as expected. Dropdown popup width matches the input width.

Evidence video to support QAgor comment (in the shortcut task):
Dropdownpopupwidthmatchestheinputwidth

@github-actions github-actions bot removed 🎪 e06b619 🚦 running Environment e06b619 status: running 🎪 e06b619 🤡 sadpandajoe Environment e06b619 requested by sadpandajoe 🎪 e06b619 📅 2026-04-09T16-21 Environment e06b619 created at 2026-04-09T16-21 🎪 e06b619 🌐 34.221.17.37:8080 Environment e06b619 URL: http://34.221.17.37:8080 (click to visit) labels Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:frontend Requires changing the frontend packages review:checkpoint Last PR reviewed during the daily review standup size/M 🎪 ⌛ 48h Environment expires after 48 hours (default)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants