fix(gantt): prevent y-axis labels from being cut off#39137
fix(gantt): prevent y-axis labels from being cut off#39137tushardhawas wants to merge 5 commits intoapache:masterfrom
Conversation
Dynamically calculate left grid padding based on the widest category label width so long y-axis labels are no longer clipped.
Code Review Agent Run #4d05cfActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
![codeant-ai-for-open-source[bot]](https://avatars.githubusercontent.com/u/151810221?s=60&v=4){kind=small}
superset-frontend/plugins/plugin-chart-echarts/src/Gantt/transformProps.ts
Outdated
Show resolved
Hide resolved
superset-frontend/plugins/plugin-chart-echarts/src/Gantt/transformProps.ts
Outdated
Show resolved
Hide resolved
…formProps.ts fix: remove label width clamp Co-authored-by: codeant-ai-for-open-source[bot] <244253245+codeant-ai-for-open-source[bot]@users.noreply.github.com>
…formProps.ts Previously, category labels were derived using a truthy check (`key ? String(key) : undefined`), which incorrectly treated valid falsy values like `0` and `false` as missing. This caused labels to not render and their widths to be excluded from grid padding calculation, leading to layout inconsistencies. Updated the logic to explicitly check for `null` and `undefined`, ensuring all valid values are preserved as labels. Co-authored-by: codeant-ai-for-open-source[bot] <244253245+codeant-ai-for-open-source[bot]@users.noreply.github.com>
Code Review Agent Run #f8a7d8Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #39137 +/- ##
=======================================
Coverage 64.52% 64.52%
=======================================
Files 2536 2536
Lines 131208 131222 +14
Branches 30457 30463 +6
=======================================
+ Hits 84661 84673 +12
- Misses 45084 45086 +2
Partials 1463 1463
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
SUMMARY
Fixes an issue where long y-axis labels in the Gantt chart were clipped and not fully visible.
The fix dynamically calculates the left grid padding based on the widest category label width, ensuring labels are not cut off regardless of length.
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION