fix(AlertReportModal): TypeError when pasting text into the Alerts content form search field by JCelento · Pull Request #39298 · apache/superset

JCelento · 2026-04-11T20:39:23Z

SUMMARY

Alerts / reports (AlertReportModal): The Chart field uses allowClear so the selection can be cleared from the UI. getChartVisualizationType returns early when the chart value is missing or invalid so /api/v1/chart/:id is not called with bad input after clear. Adds a test that clearing the chart drives the expected empty state.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

AFTER

TESTING INSTRUCTIONS

Unit tests:
cd superset-frontend && npm run test -- src/features/alerts/AlertReportModal.test.tsx` (or full suite as you prefer).
Manual :

Go to Alerts & Reports
Click + Alert and navigate to Alert Contents
Select Charts
Paste any text into the chart selection field
Expected results:
The pasted text should be used to search and filter the list of available charts, the same way typing works.

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codecov · 2026-04-11T20:56:41Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.51%. Comparing base (f850c6b) to head (6a17ec9).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #39298   +/-   ##
=======================================
  Coverage   64.51%   64.51%           
=======================================
  Files        2557     2557           
  Lines      133057   133059    +2     
  Branches    30903    30904    +1     
=======================================
+ Hits        85843    85845    +2     
  Misses      45724    45724           
  Partials     1490     1490

Flag	Coverage Δ
javascript	`66.34% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bito-code-review · 2026-04-13T13:34:41Z

Code Review Agent Run #42db95

Actionable Suggestions - 0

Review Details

Files reviewed - 4 · Commit Range: 4dc7413..08629eb
- superset-frontend/packages/superset-ui-core/src/components/Select/AsyncSelect.test.tsx
- superset-frontend/packages/superset-ui-core/src/components/Select/AsyncSelect.tsx
- superset-frontend/src/features/alerts/AlertReportModal.test.tsx
- superset-frontend/src/features/alerts/AlertReportModal.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

bito-code-review · 2026-04-13T14:56:48Z

Code Review Agent Run #d53417

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: 08629eb..52e3b57
- superset-frontend/packages/superset-ui-core/src/components/Select/AsyncSelect.test.tsx
- superset-frontend/src/features/alerts/AlertReportModal.test.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

bito-code-review · 2026-04-13T18:18:33Z

Code Review Agent Run #adf21d

Actionable Suggestions - 0

Review Details

Files reviewed - 4 · Commit Range: 0a0f8f5..fd8f980
- superset-frontend/packages/superset-ui-core/src/components/Select/AsyncSelect.test.tsx
- superset-frontend/packages/superset-ui-core/src/components/Select/AsyncSelect.tsx
- superset-frontend/src/features/alerts/AlertReportModal.test.tsx
- superset-frontend/src/features/alerts/AlertReportModal.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

msyavuz · 2026-04-14T11:14:14Z

+    if (!chart || typeof chart !== 'object' || chart.value === undefined) {
+      return;
+    }


Isn't this the actual fix? Is the optimization in AsyncSelect necessary?

That's correct. I'll remove the AsyncSelect optimization from this PR for better scoping. Do you think it is worth it for me to open another PR for the AsyncSelect optimization so that it can be reviewed with low priority?

@msyavuz rescoped and created another branch for the optimization. Thanks!

bito-code-review · 2026-04-14T14:18:33Z

Code Review Agent Run #feaf18

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: e1bc1dc..15fa0c2
- superset-frontend/src/features/alerts/AlertReportModal.test.tsx
- superset-frontend/src/features/alerts/AlertReportModal.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

bito-code-review · 2026-04-14T19:27:42Z

Code Review Agent Run #9af424

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: d29bad9..1c47852
- superset-frontend/src/features/alerts/AlertReportModal.test.tsx
- superset-frontend/src/features/alerts/AlertReportModal.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

bito-code-review · 2026-04-15T13:08:31Z

Code Review Agent Run #27471e

Actionable Suggestions - 0

Additional Suggestions - 1

superset-frontend/src/features/alerts/AlertReportModal.tsx - 1
- Missing return type hint · Line 1273-1273
  
  Per organization guidelines in BITO.md, add explicit return type hints to all functions for consistency and type safety. The getChartVisualizationType function returns either undefined (early return) or a Promise (from the API call), so annotate it accordingly to improve readability and enable better static checking.
  Code suggestion
  @@ -1273,1 +1273,1 @@ - const getChartVisualizationType = (chart: SelectValue) => { + const getChartVisualizationType = (chart: SelectValue): Promise<void> | undefined => {

Review Details

Files reviewed - 2 · Commit Range: 3250d30..7ae6ea9
- superset-frontend/src/features/alerts/AlertReportModal.test.tsx
- superset-frontend/src/features/alerts/AlertReportModal.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

… the value

…s/Select/AsyncSelect.tsx Co-authored-by: codeant-ai-for-open-source[bot] <244253245+codeant-ai-for-open-source[bot]@users.noreply.github.com>

…AlertReportModal

bito-code-review · 2026-04-16T22:54:19Z

Code Review Agent Run #610960

Actionable Suggestions - 0

Review Details

Files reviewed - 2 · Commit Range: 71b9d73..6a17ec9
- superset-frontend/src/features/alerts/AlertReportModal.test.tsx
- superset-frontend/src/features/alerts/AlertReportModal.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

pull-request-size bot added the size/M label Apr 11, 2026

JCelento marked this pull request as draft April 11, 2026 20:39

github-actions bot added the packages label Apr 11, 2026

dosubot bot added the change:frontend Requires changing the frontend label Apr 11, 2026

codeant-ai-for-open-source bot reviewed Apr 11, 2026

View reviewed changes

Comment thread superset-frontend/packages/superset-ui-core/src/components/Select/AsyncSelect.tsx Outdated

JCelento marked this pull request as ready for review April 13, 2026 13:00

dosubot bot added the alert-reports Namespace | Anything related to the Alert & Reports feature label Apr 13, 2026

pull-request-size bot added size/L and removed size/M labels Apr 13, 2026

codeant-ai-for-open-source bot reviewed Apr 13, 2026

View reviewed changes

Comment thread superset-frontend/packages/superset-ui-core/src/components/Select/AsyncSelect.tsx Outdated

JCelento force-pushed the fix/search-copy-paste branch 2 times, most recently from 7196f5b to fd8f980 Compare April 13, 2026 17:56

msyavuz reviewed Apr 14, 2026

View reviewed changes

pull-request-size bot added size/M and removed size/L labels Apr 14, 2026

github-actions bot removed the packages label Apr 14, 2026

JCelento changed the title ~~fix(AsyncSelect): call fireOnChange() only when past actually updates…~~ fix(AlertReportModal): TypeError when pasting text into the Alerts content form search field Apr 14, 2026

JCelento force-pushed the fix/search-copy-paste branch from 84491bf to 15fa0c2 Compare April 14, 2026 13:33

JCelento force-pushed the fix/search-copy-paste branch from 15fa0c2 to 1c47852 Compare April 14, 2026 18:24

JCelento force-pushed the fix/search-copy-paste branch from 1c47852 to 7ae6ea9 Compare April 15, 2026 12:04

JCelento and others added 3 commits April 16, 2026 18:52

fix(AsyncSelect): call fireOnChange() only when past actually updates…

71b9d73

… the value

fix: update superset-frontend/packages/superset-ui-core/src/component…

9b59c5f

…s/Select/AsyncSelect.tsx Co-authored-by: codeant-ai-for-open-source[bot] <244253245+codeant-ai-for-open-source[bot]@users.noreply.github.com>

test: adds missing tests to cover current changes on AsyncSelect and …

5d1fa5e

…AlertReportModal

JCelento added 4 commits April 16, 2026 18:52

fix: remove redundant fireOnChange()

3d3a363

test: improve test descriptions and naming

f010ae4

fix: use selectValueRef.current to avoid race condition

4353cf1

chore: scope PR to AlertReportModal chart clear fix

6a17ec9

JCelento force-pushed the fix/search-copy-paste branch from 7ae6ea9 to 6a17ec9 Compare April 16, 2026 21:52

Conversation

JCelento commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

AFTER

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

Uh oh!

codecov bot commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

bito-code-review bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #42db95

Uh oh!

Uh oh!

bito-code-review bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #d53417

Uh oh!

bito-code-review bot commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #adf21d

Uh oh!

msyavuz Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

JCelento Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

JCelento Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

bito-code-review bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #feaf18

Uh oh!

bito-code-review bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #9af424

Uh oh!

bito-code-review bot commented Apr 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #27471e

Uh oh!

bito-code-review bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #610960

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

JCelento commented Apr 11, 2026 •

edited

Loading

codecov bot commented Apr 11, 2026 •

edited

Loading

bito-code-review bot commented Apr 13, 2026 •

edited

Loading

bito-code-review bot commented Apr 13, 2026 •

edited

Loading

bito-code-review bot commented Apr 13, 2026 •

edited

Loading

bito-code-review bot commented Apr 14, 2026 •

edited

Loading

bito-code-review bot commented Apr 14, 2026 •

edited

Loading

bito-code-review bot commented Apr 15, 2026 •

edited

Loading

bito-code-review bot commented Apr 16, 2026 •

edited

Loading