Skip to content

feat(mcp): bump fastmcp minimum to 3.2.4 for security fixes#39349

Draft
aminghadersohi wants to merge 3 commits intoapache:masterfrom
aminghadersohi:amin/upgrade-fastmcp-3.2.4
Draft

feat(mcp): bump fastmcp minimum to 3.2.4 for security fixes#39349
aminghadersohi wants to merge 3 commits intoapache:masterfrom
aminghadersohi:amin/upgrade-fastmcp-3.2.4

Conversation

@aminghadersohi
Copy link
Copy Markdown
Contributor

@aminghadersohi aminghadersohi commented Apr 14, 2026

SUMMARY

Bumps the lower bound of the fastmcp optional dependency from >=3.1.0 to >=3.2.4 and regenerates pinned requirements via scripts/uv-pip-compile.sh.

The 3.2.1–3.2.4 releases include:

  • Security: FileUpload size validation bypass fix, proxy header leak prevention, AuthKit audience binding per RFC 8707
  • Bug fixes: json_schema_to_type crashes on Python keywords/boolean schemas/empty enums, Gemini 2.5 Flash compatibility restored
  • Auth improvements: Better JWT rejection logging (warnings with actual vs expected values), consent cookie LRU cap at 25, upstream_claims propagation in OAuthProxy

Lockfile changes: Running uv-pip-compile.sh bumps fastmcp from 3.1.0 to 3.2.4 in development.txt and adds its new transitive dependency griffelib. Other minor comment-level changes in the lockfiles are from the resolver re-evaluating dependency annotations.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A — dependency version bump only.

TESTING INSTRUCTIONS

  1. Install with pip install "apache-superset[fastmcp]"
  2. Verify fastmcp>=3.2.4 is installed
  3. Run MCP service and confirm all tools work

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration
  • Introduces new feature or API
  • Removes existing feature or API

Bumps the lower bound of the fastmcp optional dependency from >=3.1.0
to >=3.2.4. The 3.2.1-3.2.4 releases include:

- Security: FileUpload size validation bypass, proxy header leak fix,
  AuthKit audience binding per RFC 8707
- Bug fixes: json_schema_to_type crashes on Python keywords/boolean
  schemas/empty enums, Gemini 2.5 Flash compatibility
- Auth improvements: Better JWT rejection logging, consent cookie LRU
  cap at 25, upstream_claims propagation in OAuthProxy
Copilot AI review requested due to automatic review settings April 14, 2026 16:20
@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review bot commented Apr 14, 2026

Code Review Agent Run #d81baf

Actionable Suggestions - 0
Review Details
  • Files reviewed - 4 · Commit Range: b1f1168..cdfe223
    • pyproject.toml
    • requirements/base.txt
    • requirements/development.txt
    • requirements/translations.txt
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

Run uv-pip-compile to update resolved dependency versions after
bumping fastmcp lower bound to >=3.2.4.
Comment thread pyproject.toml
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the optional fastmcp dependency minimum version to pull in upstream security fixes, and regenerates pinned requirement files using a Python 3.11 solve.

Changes:

  • Bump fastmcp optional extra lower bound from >=3.1.0 to >=3.2.4.
  • Refresh pinned dependency sets in requirements/*.txt, including new/removed transitive pins.
  • Update the recorded uv pip compile commands to include --python-version 3.11.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

File Description
requirements/translations.txt Regenerated lock header to indicate a Python 3.11 compile.
requirements/development.txt Pins fastmcp==3.2.4 and refreshes transitive dev dependencies.
requirements/base.txt Updates compile header and adjusts pinned transitive dependency annotations.
pyproject.toml Raises fastmcp extra minimum version to 3.2.4.

Comment thread requirements/development.txt Outdated
Comment thread requirements/development.txt Outdated
Comment thread requirements/development.txt
Comment thread requirements/development.txt
Comment thread requirements/development.txt Outdated
Comment thread requirements/base.txt Outdated
Comment thread requirements/translations.txt Outdated
Re-run scripts/uv-pip-compile.sh inside Docker (Python 3.11 on Linux)
to produce lockfiles consistent with CI. Previous local compile on
macOS missed Linux-only deps (secretstorage, jeepney) and included
Python <3.11 deps (async-timeout, tomli) that don't apply.
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.45%. Comparing base (002d8ad) to head (e105e47).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #39349   +/-   ##
=======================================
  Coverage   64.45%   64.45%           
=======================================
  Files        2555     2555           
  Lines      132721   132721           
  Branches    30802    30802           
=======================================
  Hits        85539    85539           
  Misses      45696    45696           
  Partials     1486     1486           
Flag Coverage Δ
hive 39.96% <ø> (ø)
mysql 60.60% <ø> (ø)
postgres 60.68% <ø> (ø)
presto 41.75% <ø> (ø)
python 62.26% <ø> (ø)
sqlite 60.31% <ø> (ø)
unit 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review bot commented Apr 14, 2026

Code Review Agent Run #3338f0

Actionable Suggestions - 0
Review Details
  • Files reviewed - 3 · Commit Range: b1f1168..e105e47
    • requirements/base.txt
    • requirements/development.txt
    • requirements/translations.txt
  • Files skipped - 0
  • Tools
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants