Skip to content

feat: add Databricks metric views semantic layer extension#39366

Draft
drummerwolli wants to merge 17 commits intoapache:semantic-layer-rename-database-datasetfrom
drummerwolli:databricks-metric-views-poc
Draft

feat: add Databricks metric views semantic layer extension#39366
drummerwolli wants to merge 17 commits intoapache:semantic-layer-rename-database-datasetfrom
drummerwolli:databricks-metric-views-poc

Conversation

@drummerwolli
Copy link
Copy Markdown
Contributor

Add a Superset extension (.supx) for Databricks Unity Catalog metric views as a semantic layer type. Includes:

  • Databricks metric views extension (layer, view, client, schemas)
  • Fix InMemoryFinder publisher prefix alias registration
  • Fix KeyError when filter has no val key in semantic layer mapper
  • Fix TEMPORAL_RANGE filter resolution for human-readable values (e.g. Last week)
  • Fix time_grain_sqla None crash in mapper

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review bot commented Apr 15, 2026

Bito Automatic Review Skipped - Branch Excluded

Bito didn't auto-review because the source or target branch is excluded from automatic reviews.
No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the branch exclusion settings here, or contact your Bito workspace admin at evan@preset.io.

Add a Superset extension (.supx) for Databricks Unity Catalog metric views
as a semantic layer type. Includes:

- Databricks metric views extension (layer, view, client, schemas)
- Fix InMemoryFinder publisher prefix alias registration
- Fix KeyError when filter has no val key in semantic layer mapper
- Fix TEMPORAL_RANGE filter resolution for human-readable values (e.g. Last week)
- Fix time_grain_sqla None crash in mapper
@drummerwolli drummerwolli force-pushed the databricks-metric-views-poc branch from af727b5 to 4777f84 Compare April 15, 2026 13:24
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 15, 2026

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit af727b5
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/69df9178b961ee0008b9b119
😎 Deploy Preview https://deploy-preview-39366--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 15, 2026

Deploy Preview for superset-docs-preview ready!

Name Link
🔨 Latest commit 4777f84
🔍 Latest deploy log https://app.netlify.com/projects/superset-docs-preview/deploys/69df91acf357b90008f1eb21
😎 Deploy Preview https://deploy-preview-39366--superset-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

❌ Patch coverage is 3.57143% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.22%. Comparing base (aa98f34) to head (4777f84).

Files with missing lines Patch % Lines
superset/semantic_layers/mapper.py 5.88% 16 Missing ⚠️
superset/extensions/utils.py 0.00% 11 Missing ⚠️
Additional details and impacted files
@@                            Coverage Diff                             @@
##           semantic-layer-rename-database-dataset   #39366      +/-   ##
==========================================================================
- Coverage                                   64.61%   63.22%   -1.40%     
==========================================================================
  Files                                        1822     2544     +722     
  Lines                                       72962   130725   +57763     
  Branches                                    23236    30037    +6801     
==========================================================================
+ Hits                                        47148    82645   +35497     
- Misses                                      25814    46625   +20811     
- Partials                                        0     1455    +1455     
Flag Coverage Δ
hive 40.38% <3.57%> (?)
mysql 61.10% <3.57%> (?)
postgres 61.16% <3.57%> (?)
presto 40.40% <3.57%> (?)
python 61.42% <3.57%> (?)
sqlite 60.80% <3.57%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@betodealmeida betodealmeida force-pushed the semantic-layer-rename-database-dataset branch 2 times, most recently from 0765573 to e5224cb Compare April 16, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants