fix(radar): correct legend margin control in the radar chart

[vhogberg]

SUMMARY

Margin control on the legend of radar charts had no effect. Compute a shifted center based on legendMargin and legendOrientation to move the chart in the appropriate direction and make room for the legend.

What changed

• Added LegendOrientation import and used it to compute radar center offsets.
• Introduced legend-margin-based positioning logic:
• resolvedMargin from legendMargin (only when showLegend is true).
• offsetX / offsetY calculated from chart width/height.
• centerX / centerY defaults (50, 50) adjusted by legend orientation.
• New radarCenter passed into radar config via center.

TESTING INSTRUCTIONS

Create a Radar Chart with at least 3–5 categories/series so legend is visible. Then, in the control panel:

• Enable Show legend.
• Set legend position to Left, then vary Legend margin (e.g. 0, 20, 60, 120).
• Repeat for Right, Top, and Bottom.
• The radar plot center shifts in the expected axis direction based on legend orientation.
• Increasing legend margin increases separation from the legend area.
• No overlap/clipping regressions for labels or radar shape.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #93a151

Actionable Suggestions - 1

• superset-frontend/plugins/plugin-chart-echarts/src/Radar/transformProps.ts - 1

  • Logic Bug · Line 365-381

Review Details

• Files reviewed - 1 · Commit Range: 345ea28..345ea28

  • superset-frontend/plugins/plugin-chart-echarts/src/Radar/transformProps.ts
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • Eslint (Linter) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[bito-code-review]

Code Review Agent Run #b2da41

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: 345ea28..94f210c

  • superset-frontend/plugins/plugin-chart-echarts/src/Radar/transformProps.ts
• Files skipped - 0
• Tools

  • Eslint (Linter) - ✔︎ Successful
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by